Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752410AbdLELbL (ORCPT ); Tue, 5 Dec 2017 06:31:11 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:38122 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269AbdLELbH (ORCPT ); Tue, 5 Dec 2017 06:31:07 -0500 X-Google-Smtp-Source: AGs4zMZSQUVxwWgAMH3OrPav8tV9GalKBWOV1themLvKO66GzaNKdxsbOlfmDLKOnjP0XWD5A7s3FHrJdTvukrNR7CE= MIME-Version: 1.0 In-Reply-To: References: <20171114123834.xsjiy2ynvott4gae@brain> <1511780854-7213-1-git-send-email-paolo.pisati@canonical.com> From: Paolo Pisati Date: Tue, 5 Dec 2017 12:31:04 +0100 Message-ID: Subject: Re: [PATCH v3] scripts/package: snap-pkg target To: Riku Voipio Cc: Masahiro Yamada , Jim Davis , Michal Marek , Behan Webster , Matthias Kaehlcke , =?UTF-8?Q?Vin=C3=ADcius_Tinti?= , linux-kbuild , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 740 Lines: 19 On Fri, Dec 1, 2017 at 1:03 PM, Riku Voipio wrote: > > Since you are already patching snapcraft for this, why not embed the > whole support in snapcraft? Eg something like snapcraft --kernel > /path/to/kernel > > The key advantage you'll get is being able to support old kernel versions too. There's a lot more you can do inside a snapcraft.yaml (bundle external files, override .config options, run pre or post scripts, etc) but by embedding everything inside the kernel/kbuild plugins you would loose all these options, and people would loose visibility of these opportunities. Besides, snapcraft requires a snapcraft.yaml by design, and i can't remove that (such a change would never be accepted). -- bye, p.