From: "Takiguchi, Yasunari" <Yasunari.Takiguchi@sony.com>
To: Sean Young <sean@mess.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "tbird20d@gmail.com" <tbird20d@gmail.com>,
        "frowand.list@gmail.com" <frowand.list@gmail.com>,
        "Yamamoto, Masayuki" <Masayuki.Yamamoto@sony.com>,
        "Nozawa, Hideki (STWN)" <Hideki.Nozawa@sony.com>,
        "Yonezawa, Kota" <Kota.Yonezawa@sony.com>,
        "Matsumoto, Toshihiko" <Toshihiko.Matsumoto@sony.com>,
        "Watanabe, Satoshi (SSS)" <Satoshi.C.Watanabe@sony.com>,
        "Takiguchi, Yasunari" <Yasunari.Takiguchi@sony.com>
Subject: RE: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver
Thread-Topic: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver
Thread-Index: AQHTQ+lYDGbIYElXxUCPgoTA2lXmjaMyjNgAgAJkLSA=
Date: Tue, 5 Dec 2017 11:47:11 +0000
Message-ID: <02699364973B424C83A42A84B04FDA8542C075@JPYOKXMS113.jp.sony.com>
References: <20171013054635.20946-1-Yasunari.Takiguchi@sony.com>
 <20171013060934.21612-1-Yasunari.Takiguchi@sony.com>
 <20171203225911.v6unmy5b2k3yc2tf@gofer.mess.org>
In-Reply-To: <20171203225911.v6unmy5b2k3yc2tf@gofer.mess.org>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2017 11:47:14.7872
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d26442d1-8f92-437c-d703-08d53bd5ee2b
X-MS-Exchange-CrossTenant-Id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=66c65d8a-9158-4521-a2d8-664963db48e4;Ip=[117.103.190.43];Helo=[jp.sony.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1301MB2028
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 623
Lines: 27

Dear Sean

Hi, Thanks for your review.

We will refer to your comments and consider how to respond for them.

> > +	u8 rdata[2];
> > +	int ret;
> > +
> > +	if ((!tnrdmd) || (!pre_bit_err) || (!pre_bit_count))
> > +		return -EINVAL;
> > +
> > +	if (tnrdmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SUB)
> > +		return -EINVAL;
> 
> divermode: this should say drivermode, correct?

diver_mode is not typo, because cxd2880 has diversity function.

> > +MODULE_DESCRIPTION(
> > +"Sony CXD2880 DVB-T2/T tuner + demodulator drvier");
> 
> drvier => driver
Yes. It is typo. We will also re-check other patch files.

Thanks
Takiguchi