Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752593AbdLEM0U (ORCPT ); Tue, 5 Dec 2017 07:26:20 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:37449 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbdLEM0T (ORCPT ); Tue, 5 Dec 2017 07:26:19 -0500 Subject: Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps] To: Alexey Brodkin References: <1512387175.4977.24.camel@synopsys.com> <86238def-82be-2ad1-63d0-b9a8dbf83db6@synopsys.com> <1512393408.4977.44.camel@synopsys.com> <1512399218.4977.48.camel@synopsys.com> <1512403237.4977.54.camel@synopsys.com> <232eae49-ddbb-fd87-2b35-6db47817e23e@synopsys.com> <1512408586.4977.73.camel@synopsys.com> <1512474815.4977.90.camel@synopsys.com> CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "airlied@gmail.com" , "airlied@redhat.com" , "daniel.vetter@ffwll.ch" , "linux-snps-arc@lists.infradead.org" , "l.stach@pengutronix.de" From: Jose Abreu Message-ID: <335eaaa2-b209-fb60-392f-93036050b406@synopsys.com> Date: Tue, 5 Dec 2017 12:26:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1512474815.4977.90.camel@synopsys.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.63] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 787 Lines: 16 On 05-12-2017 11:53, Alexey Brodkin wrote: > > From my note above about udl_drm_gem_mmap() being only used in case of Xserver > I barely may conclude anything. Given my lack of knowledge of DRM guts > especially > when it comes to complicated cases with DMA buffer exports/imports I cannot say > immediately if that's just improper implementation of > udl_drm_gem_mmap() or not. > Even though I do see some differences between implementation of file_operations->mmap() > callback in UDL and > say exynos_drm_gem_mmap() or qxl_mmap() it's not clear > why this and that implementation was done. Oh, I've seen this before. This is the same thing that arcpgu used to do in the mmap callback! Please comment out the call to update_vm_cache_attr() in the mmap callback and check if it works.