From: Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
To: "'Arnd Bergmann'" <arnd@arndb.de>
CC: gregkh <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Michal Simek <michal.simek@xilinx.com>, "Hyun Kwon" <hyunk@xilinx.com>
Subject: RE: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU
 logicoreIP init driver
Thread-Topic: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU
 logicoreIP init driver
Thread-Index: AQHTbb/vvsNWt82zs0iPUUhWqjiWdqM0qvKAgAAClLA=
Date: Tue, 5 Dec 2017 12:38:21 +0000
Message-ID: <BY2PR0201MB1879415B035843E955D98393C13D0@BY2PR0201MB1879.namprd02.prod.outlook.com>
References: <1512474212-12803-1-git-send-email-dshah@xilinx.com>
 <CAK8P3a3AbzBkxfhffnS3K-ehd1kQC1okyh5NF4OMBYPWwZ+KpQ@mail.gmail.com>
In-Reply-To: <CAK8P3a3AbzBkxfhffnS3K-ehd1kQC1okyh5NF4OMBYPWwZ+KpQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cd922c4-1c3a-4cde-b9c9-08d53bdd11e8
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2017 12:38:21.4725
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0201MB0994
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vB5CcdhQ018199
Content-Length: 1670
Lines: 28

Hi Arnd,

Thanks a lot for the review.
Replies inline.

-----Original Message-----
From: arndbergmann@gmail.com [mailto:arndbergmann@gmail.com] On Behalf Of Arnd Bergmann
Sent: Tuesday, December 05, 2017 4:19 AM
To: Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
Cc: gregkh <gregkh@linuxfoundation.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Michal Simek <michal.simek@xilinx.com>; Hyun Kwon <hyunk@xilinx.com>; Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
Subject: Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver

On Tue, Dec 5, 2017 at 12:43 PM, Dhaval Shah <dhaval.shah@xilinx.com> wrote:
> Xilinx ZYNQMP VCU Init driver is based on the new LogiCoreIP design 
> created. This driver will provide the api which can be used by the 
> encoder and decoder driver to get the configured value.
>
> Signed-off-by: Dhaval Shah <dshah@xilinx.com>

Can you explain what a "VCU" is and why there is no existing subsystem for it?

[Dhaval] : This VCU means Video codec unit. Here, this driver is for the logicoreIP and not the VCU which is created to support the PS and PL isolation and to provide the clock related information. So this is not a VCU driver and but just a intermediate driver which supports logicoreIP. That's why no subsystem for this.

If this is the "video codec unit", I'd suggest moving it to drivers/media/platform and sending the patch to the linux-media@vger.kernel.org list instead.
[Dhaval] : This is not the Video codec unit but the driver to provide the support the IP created for the PS and PL isolation and clock related information. That why I have placed this under the "drivers/misc/".


      Arnd