Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752835AbdLENFJ (ORCPT ); Tue, 5 Dec 2017 08:05:09 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:43016 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbdLENFH (ORCPT ); Tue, 5 Dec 2017 08:05:07 -0500 Date: Tue, 5 Dec 2017 13:04:46 +0000 From: Mark Brown To: Nicolin Chen Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, fabio.estevam@nxp.com, timur@tabi.org, mail@maciej.szmigiero.name, caleb@crome.org, lgirdwood@gmail.com Subject: Re: [PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device Message-ID: <20171205130446.GI11658@finisterre> References: <1512420403-10164-1-git-send-email-nicoleotsuka@gmail.com> <1512420403-10164-2-git-send-email-nicoleotsuka@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7IgncvKP0CVPV/ZZ" Content-Disposition: inline In-Reply-To: <1512420403-10164-2-git-send-email-nicoleotsuka@gmail.com> X-Cookie: Keep cool. User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1063 Lines: 30 --7IgncvKP0CVPV/ZZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 04, 2017 at 12:46:34PM -0800, Nicolin Chen wrote: > struct device is defined in system level header files any way. > As long as fsl_ssi.h is included after those header files, it > should be safe to remove this line. It's better practice to either directly include those headers or have a forward declaration like this, it means there's no way things can go wrong. --7IgncvKP0CVPV/ZZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlommW0ACgkQJNaLcl1U h9DKngf9G0hdTAKCrt5SUpPnTKgEfzhkb8uVISWw9YmR/iqZcz2Aob1jJKc/J5UB fP+P+Jk+FTHbUPznEowCL7GJtOiB215wYCbb2aSYMV/Y+Q3RpAPEOijEnbWxR/kh eIzpxIbF+zWeHLqW5GXEQ9fc3w6uvoP3LzZqBX9rClD/GpRar1JJOvCHFt67pYE7 K6ST4N+L5Hf1xmNtfDboNYQHuhkVYZXv1X3AWK1cajpZSfjuFerau232zc8KpiUT XO3eh3c/BETO4D74ffsMKIz8QobJPjlM4DNlpzhBiD1/5FBp+YjSn72L21G9JP6f /vWs3Be/ifI8LPq+R42KSpmfmnMmxw== =z7pP -----END PGP SIGNATURE----- --7IgncvKP0CVPV/ZZ--