Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbdLENcY (ORCPT ); Tue, 5 Dec 2017 08:32:24 -0500 Received: from mail-ot0-f196.google.com ([74.125.82.196]:41334 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126AbdLENcX (ORCPT ); Tue, 5 Dec 2017 08:32:23 -0500 X-Google-Smtp-Source: AGs4zMYFYrU3/GHIaw+Xw1QK+1twvF9FIuxcfVQmGSCThC5ON4cVARBTC7bU/t5gB90HShIlIpKaoIU6mWHNkWwuF9k= MIME-Version: 1.0 In-Reply-To: References: <1512474212-12803-1-git-send-email-dshah@xilinx.com> From: Arnd Bergmann Date: Tue, 5 Dec 2017 14:32:22 +0100 X-Google-Sender-Auth: E69T9UV-wOf4YDvbfG405P5eops Message-ID: Subject: Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver To: Dhaval Rajeshbhai Shah Cc: gregkh , Linux Kernel Mailing List , Michal Simek , Hyun Kwon Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vB5DWVvA031205 Content-Length: 1888 Lines: 28 On Tue, Dec 5, 2017 at 1:38 PM, Dhaval Rajeshbhai Shah wrote: > From: arndbergmann@gmail.com [mailto:arndbergmann@gmail.com] On Behalf Of Arnd Bergmann > Sent: Tuesday, December 05, 2017 4:19 AM > To: Dhaval Rajeshbhai Shah > Cc: gregkh ; Linux Kernel Mailing List ; Michal Simek ; Hyun Kwon ; Dhaval Rajeshbhai Shah > Subject: Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver > > On Tue, Dec 5, 2017 at 12:43 PM, Dhaval Shah wrote: >> Xilinx ZYNQMP VCU Init driver is based on the new LogiCoreIP design >> created. This driver will provide the api which can be used by the >> encoder and decoder driver to get the configured value. >> >> Signed-off-by: Dhaval Shah > > Can you explain what a "VCU" is and why there is no existing subsystem for it? > > [Dhaval] : This VCU means Video codec unit. Here, this driver is for the logicoreIP and not the VCU which is created to support the PS and PL isolation and to provide the clock related information. So this is not a VCU driver and but just a intermediate driver which supports logicoreIP. That's why no subsystem for this. What are PS and PL then? > If this is the "video codec unit", I'd suggest moving it to drivers/media/platform and sending the patch to the linux-media@vger.kernel.org list instead. > [Dhaval] : This is not the Video codec unit but the driver to provide the support the IP created for the PS and PL isolation and clock related information. That why I have placed this under the "drivers/misc/". Is the driver useful without a codec driver then? (I assume this will be answered when you explain PS and PL). If not, just put it in the same directory as the codec. Arnd