Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753085AbdLEPsj (ORCPT ); Tue, 5 Dec 2017 10:48:39 -0500 Received: from mail-vk0-f66.google.com ([209.85.213.66]:36187 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752844AbdLEPsf (ORCPT ); Tue, 5 Dec 2017 10:48:35 -0500 X-Google-Smtp-Source: AGs4zMabp+2lW9S0g8Vo0gqFx9o0yh+WUT2YElB1WzrldIzs2hiEKgdVzFNWkG50qdl2mtz+faLuDQ== Date: Tue, 5 Dec 2017 07:48:31 -0800 From: Tejun Heo To: Wang Long Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, w@laoqinren.net Subject: Re: [PATCH] writeback: fix comment in __mark_inode_dirty Message-ID: <20171205154831.GR2421075@devbig577.frc2.facebook.com> References: <1512453174-25575-1-git-send-email-wanglong19@meituan.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512453174-25575-1-git-send-email-wanglong19@meituan.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 735 Lines: 28 Hello, Wang. On Tue, Dec 05, 2017 at 12:52:54AM -0500, Wang Long wrote: > Signed-off-by: Wang Long > --- > fs/fs-writeback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index cea4836..8d477cf 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -2209,7 +2209,7 @@ void __mark_inode_dirty(struct inode *inode, int flags) > trace_writeback_dirty_inode_enqueue(inode); > > /* > - * If this is the first dirty inode for this bdi, > + * If this is the first dirty inode for this wb, Acked-by: Tejun Heo This probably should go through the block tree tho. Please cc Jens Axboe. Thanks. -- tejun