Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752894AbdLEPwu (ORCPT ); Tue, 5 Dec 2017 10:52:50 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:33199 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752732AbdLEPwp (ORCPT ); Tue, 5 Dec 2017 10:52:45 -0500 X-Google-Smtp-Source: AGs4zMYJ6GhxGFD1WBGCtxm13g/z2C7zDQQOtlNe6Z97ViQ+LdJNAi1YLvP+QW8UPBJQVQ34WBEqsQ== From: Loys Ollivier To: Andy Gross , David Brown Cc: Loys Ollivier , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Brunet Subject: [PATCH] firmware: qcom: scm: Fix incorrect of_node_put call in scm_init Date: Tue, 5 Dec 2017 16:52:14 +0100 Message-Id: <1512489134-28220-1-git-send-email-lollivier@baylibre.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 913 Lines: 29 When using other platform architectures, in the init of the qcom_scm driver, of_node_put is called on /firmware if no qcom dt is found. This results in a kernel error: Bad of_node_put() on /firmware. The call to of_node_put from the qcom_scm init is unnecessary as of_find_matching_node is calling it automatically. Remove this of_node_put(). Fixes: d0f6fa7ba2d6 ("firmware: qcom: scm: Convert SCM to platform driver") Signed-off-by: Loys Ollivier --- drivers/firmware/qcom_scm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index af4c75217ea6..575930c80fba 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -633,7 +633,6 @@ static int __init qcom_scm_init(void) np = of_find_matching_node(fw_np, qcom_scm_dt_match); if (!np) { - of_node_put(fw_np); return -ENODEV; } -- 2.7.4