Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbdLEQQv (ORCPT ); Tue, 5 Dec 2017 11:16:51 -0500 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:51161 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbdLEQQr (ORCPT ); Tue, 5 Dec 2017 11:16:47 -0500 X-IronPort-AV: E=Sophos;i="5.45,364,1508774400"; d="scan'208";a="64028892" From: Bart Van Assche To: "osandov@osandov.com" , "jthumshirn@suse.de" , "ming.lei@redhat.com" CC: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "hch@infradead.org" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , "axboe@fb.com" , "hare@suse.com" , "holger@applied-asynchrony.com" , "jejb@linux.vnet.ibm.com" Subject: Re: [PATCH] SCSI: run queue if SCSI device queue isn't ready and queue is idle Thread-Topic: [PATCH] SCSI: run queue if SCSI device queue isn't ready and queue is idle Thread-Index: AQHTbZ4g7T3yQq9yCkKeO51Qk7DLeaM0z9Y0gAAdzoA= Date: Tue, 5 Dec 2017 16:16:44 +0000 Message-ID: <1512490603.2660.13.camel@sandisk.com> References: <20171205075256.10319-1-ming.lei@redhat.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.171] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1536;20:5OaxX/ZsDRFDnD+eR5HDxVUHv15w0AYqkuByyDdFxHcl82pwsZmDzqwSZyijD8a4fYpWjRSE2uMJcQUS4EoeTTYB1qAeABUHY2ZzPH1qX0xjXI7EqKoi8yMqy+iMhEgwkiRaN1m6dE/gIhpPoVguDlGk4qimlkMpUkp80M8ebxA= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: b51cda8e-02e9-4be6-a888-08d53bfb93b6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603286);SRVR:CY1PR0401MB1536; x-ms-traffictypediagnostic: CY1PR0401MB1536: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(3231022)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(6072148)(201708071742011);SRVR:CY1PR0401MB1536;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR0401MB1536; x-forefront-prvs: 0512CC5201 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(366004)(376002)(346002)(377424004)(189002)(199003)(24454002)(77096006)(229853002)(2906002)(478600001)(68736007)(66066001)(6486002)(6436002)(8676002)(36756003)(7416002)(72206003)(6506006)(81166006)(81156014)(6246003)(76176011)(25786009)(9686003)(3660700001)(99286004)(2501003)(33896003)(86362001)(3280700002)(53936002)(6512007)(97736004)(4326008)(5660300001)(6116002)(102836003)(8936002)(33646002)(2201001)(3846002)(305945005)(7736002)(54906003)(2900100001)(110136005)(316002)(106356001)(103116003)(14454004)(189998001)(2950100002)(105586002)(101416001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1536;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: b51cda8e-02e9-4be6-a888-08d53bfb93b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2017 16:16:44.2907 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB5GH4fr004225 Content-Length: 619 Lines: 15 On Tue, 2017-12-05 at 15:29 +0100, Johannes Thumshirn wrote: > 1) Testing without the patch applied hangs the test forever as it > doesn't get killed after a specific timeout (I think this should be > solved in a common function). Hello Johannes, If a request queue got stuck then the processes that submitted the requests on that queue are unkillable. The only approach I know of to stop these processes is to send a kill signal and next to trigger a queue run from user space. One possible approach is to run the following command: for d in /sys/kernel/debug/block/*; do echo kick >$d/state; done Bart.