Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608AbdLEQsl (ORCPT ); Tue, 5 Dec 2017 11:48:41 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:36926 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbdLEQsg (ORCPT ); Tue, 5 Dec 2017 11:48:36 -0500 Date: Tue, 05 Dec 2017 11:48:33 -0500 (EST) Message-Id: <20171205.114833.2112478522356368321.davem@davemloft.net> To: salil.mehta@huawei.com Cc: yisen.zhuang@huawei.com, lipeng321@huawei.com, mehta.salil.lnk@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver From: David Miller In-Reply-To: <20171204012955.17560-1-salil.mehta@huawei.com> References: <20171204012955.17560-1-salil.mehta@huawei.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Dec 2017 08:48:35 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1590 Lines: 37 From: Salil Mehta Date: Mon, 4 Dec 2017 01:29:52 +0000 > This patch refactors the code of the reset feature in HCLGE layer > of HNS3 PF driver. Prime motivation to do this change is: > 1. To reduce the time for which common miscellaneous Vector 0 > interrupt is disabled because of the reset. Simplification > of the common miscellaneous interrupt handler routine(for > Vector 0) used to handle reset and other sources of Vector > 0 interrupt. > 2. Separate the task for handling the reset > 3. Simplification of reset request submission and pending reset > logic. > > > To achieve above below few things have been done: > 1. Interrupt is disabled while common miscellaneous interrupt > handler is entered and re-enabled before it is exit. This > reduces the interrupt handling latency as compared to older > interrupt handling scheme where interrupt was being disabled > in interrupt handler context and re-enabled in task context > some time later. Made Miscellaneous interrupt handler more > generic to handle all sources including reset interrupt source. > 2. New reset service task has been introduced to service the > reset handling. > 3. Introduces new reset service task for honoring software reset > requests like from network stack related to timeout and serving > the pending reset request(to reset the driver and associated > clients). > > > Change Log: > Patch V2: Addressed comment by Andrew Lunn > Link: https://lkml.org/lkml/2017/12/1/366 > Patch V1: Initial Submit Series applied, thank you.