Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752690AbdLEQ7a convert rfc822-to-8bit (ORCPT ); Tue, 5 Dec 2017 11:59:30 -0500 Received: from lhrrgout.huawei.com ([194.213.3.17]:2992 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752705AbdLEQ7Y (ORCPT ); Tue, 5 Dec 2017 11:59:24 -0500 From: Salil Mehta To: David Miller CC: "Zhuangyuzeng (Yisen)" , "lipeng (Y)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Linuxarm Subject: RE: [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver Thread-Topic: [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver Thread-Index: AQHTbJ9/C38t5qGgvUielTY4gFd42KM058OAgAATlFA= Date: Tue, 5 Dec 2017 16:59:14 +0000 Message-ID: References: <20171204012955.17560-1-salil.mehta@huawei.com> <20171205.114833.2112478522356368321.davem@davemloft.net> In-Reply-To: <20171205.114833.2112478522356368321.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.226.117] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2190 Lines: 50 > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Tuesday, December 05, 2017 4:49 PM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen) ; lipeng (Y) > ; mehta.salil.lnk@gmail.com; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > rdma@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" > handling code in HCLGE layer of HNS3 driver > > From: Salil Mehta > Date: Mon, 4 Dec 2017 01:29:52 +0000 > > > This patch refactors the code of the reset feature in HCLGE layer > > of HNS3 PF driver. Prime motivation to do this change is: > > 1. To reduce the time for which common miscellaneous Vector 0 > > interrupt is disabled because of the reset. Simplification > > of the common miscellaneous interrupt handler routine(for > > Vector 0) used to handle reset and other sources of Vector > > 0 interrupt. > > 2. Separate the task for handling the reset > > 3. Simplification of reset request submission and pending reset > > logic. > > > > > > To achieve above below few things have been done: > > 1. Interrupt is disabled while common miscellaneous interrupt > > handler is entered and re-enabled before it is exit. This > > reduces the interrupt handling latency as compared to older > > interrupt handling scheme where interrupt was being disabled > > in interrupt handler context and re-enabled in task context > > some time later. Made Miscellaneous interrupt handler more > > generic to handle all sources including reset interrupt source. > > 2. New reset service task has been introduced to service the > > reset handling. > > 3. Introduces new reset service task for honoring software reset > > requests like from network stack related to timeout and serving > > the pending reset request(to reset the driver and associated > > clients). > > > > > > Change Log: > > Patch V2: Addressed comment by Andrew Lunn > > Link: https://lkml.org/lkml/2017/12/1/366 > > Patch V1: Initial Submit > > Series applied, thank you. Thanks Dave.