Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038AbdLESIN (ORCPT ); Tue, 5 Dec 2017 13:08:13 -0500 Received: from mail2.skidata.com ([91.230.2.91]:47566 "EHLO mail2.skidata.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546AbdLESIH (ORCPT ); Tue, 5 Dec 2017 13:08:07 -0500 X-IronPort-AV: E=Sophos;i="5.45,364,1508796000"; d="scan'208";a="1142538" Subject: Re: [PATCH net-next v3 2/4] phylib: add reset after clk enable support To: Andrew Lunn , Richard Leitner CC: , , , , , , , , , , , , , References: <20171205132600.13796-1-dev@g0hl1n.net> <20171205132600.13796-3-dev@g0hl1n.net> <20171205173407.GN12805@lunn.ch> From: Richard Leitner Message-ID: Date: Tue, 5 Dec 2017 19:08:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171205173407.GN12805@lunn.ch> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.24.99] X-ClientProxiedBy: sdex1srv.skidata.net (172.16.10.92) To sdex1srv.skidata.net (172.16.10.92) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1348 Lines: 39 Hi Andrew, On 12/05/2017 06:34 PM, Andrew Lunn wrote: > On Tue, Dec 05, 2017 at 02:25:58PM +0100, Richard Leitner wrote: >> From: Richard Leitner >> >> Some PHYs need the refclk to be a continuous clock. Therefore they don't >> allow turning it off and on again during operation. Nonetheless such a >> clock switching is performed by some ETH drivers (namely FEC [1]) for >> power saving reasons. An example for an affected PHY is the >> SMSC/Microchip LAN8720 in "REF_CLK In Mode". >> >> In order to provide a uniform method to overcome this problem this patch >> adds a new phy_driver flag (PHY_RST_AFTER_CLK_EN) and corresponding >> function phy_reset_after_clk_enable() to the phylib. These should be >> used to trigger reset of the PHY after the refclk is switched on again. >> >> This patch depends on the "phylib: Add device reset GPIO support" patch >> submitted by Geert Uytterhoeven/Sergei Shtylyov [2]. >> >> [1] commit e8fcfcd5684a ("net: fec: optimize the clock management to save power") >> [2] https://patchwork.kernel.org/patch/10090149/ >> >> Signed-off-by: Richard Leitner > > Hi Richard > > Same comment about moving text below the --- Ok. Thanks for your feedback and review. > > Reviewed-by: Andrew Lunn > regards;Richard.L > Andrew >