Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbdLESUI (ORCPT ); Tue, 5 Dec 2017 13:20:08 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:38534 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312AbdLESUH (ORCPT ); Tue, 5 Dec 2017 13:20:07 -0500 X-Google-Smtp-Source: AGs4zMZAIhC9MikBnqsKPUziJnSK6Ff8kWA31rkKatApl/saHniFMY3r9R7+nzGmyCgHBdpMkY0GRQ== Date: Tue, 5 Dec 2017 10:20:03 -0800 From: Dmitry Torokhov To: Arvind Yadav Cc: gregkh@linuxfoundation.org, davem@davemloft.net, linus.walleij@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] driver-core: platform: Avoid to return IRQ 0 in platform_get_irq() Message-ID: <20171205182003.oto6qnus3e3vy64f@dtor-ws> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1169 Lines: 41 On Tue, Dec 05, 2017 at 11:41:52PM +0530, Arvind Yadav wrote: > Function platform_get_irq() can return 0. Which means NO_IRQ. > So this change will not allow to return 0. > > This change is help to use platform_get_irq() without this, > > val = platform_get_irq(); > if (val <= 0) > ret = val ? val : -ENODEV; > > Signed-off-by: Arvind Yadav You need to audit the drivers and make sure you are not breaking them with this. I believe at least i2c designware controller on certain boards has DEFINE_RES_IRQ(0) which will be broken by this patch. > --- > drivers/base/platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index c203fb9..7b3079c 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -127,7 +127,7 @@ int platform_get_irq(struct platform_device *dev, unsigned int num) > irqd_set_trigger_type(irqd, r->flags & IORESOURCE_BITS); > } > > - return r ? r->start : -ENXIO; > + return r && r->start ? r->start : -ENXIO; > #endif > } > EXPORT_SYMBOL_GPL(platform_get_irq); > -- > 2.7.4 > Thanks. -- Dmitry