Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751944AbdLETre (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Dec 2017 14:47:34 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:39438 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751112AbdLETr3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Dec 2017 14:47:29 -0500
Date: Tue, 05 Dec 2017 14:47:27 -0500 (EST)
Message-Id: <20171205.144727.522098543209254657.davem@davemloft.net>
To: vivien.didelot@savoirfairelinux.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch
Subject: Re: [PATCH net-next 0/5] net: dsa: use per-port upstream port
From: David Miller <davem@davemloft.net>
In-Reply-To: <20171204173457.14873-1-vivien.didelot@savoirfairelinux.com>
References: <20171204173457.14873-1-vivien.didelot@savoirfairelinux.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Dec 2017 11:47:28 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 883
Lines: 23

From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Mon,  4 Dec 2017 12:34:52 -0500

> An upstream port is a local switch port used to reach a CPU port.
> 
> DSA still considers a unique CPU port in the whole switch fabric and
> thus return a unique upstream port for a given switch. This is wrong in
> a multiple CPU ports environment.
> 
> We are now switching to using the dedicated CPU port assigned to each
> port in order to get rid of the deprecated unique tree CPU port.
> 
> This patchset makes the dsa_upstream_port() helper take a port argument
> and goes one step closer complete support for multiple CPU ports.

Please adhere to reverse-christmas-tree for variable declarations in
these changes.

I know it can be a pain when there are inter-variable dependencies
wrt. assignments, but just move it below the declaration and into a
real statement.

Thanks.