Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752361AbdLETuM (ORCPT ); Tue, 5 Dec 2017 14:50:12 -0500 Received: from mail-qt0-f181.google.com ([209.85.216.181]:36701 "EHLO mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752252AbdLETtv (ORCPT ); Tue, 5 Dec 2017 14:49:51 -0500 X-Google-Smtp-Source: AGs4zMaEKknerEUUnE547PWeSBPxOa2JLF62sWTR/UFkhxH9qhqitxdD+99jyHIaSoiLK/49w7a+PA== Date: Tue, 5 Dec 2017 11:49:48 -0800 From: Tejun Heo To: Arvind Yadav Cc: b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH v2] pata_pdc2027x: Fix coding sytle errors Message-ID: <20171205194948.GY2421075@devbig577.frc2.facebook.com> References: <1512498399-23577-1-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512498399-23577-1-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 24 On Tue, Dec 05, 2017 at 11:56:38PM +0530, Arvind Yadav wrote: > Fix these checkpatch.pl errors: > Fix checkpatch.pl error: > ERROR: space prohibited before open square bracket '['. > > ERROR: space prohibited after that '~' (ctx:WxW) > + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); > > ERROR: spaces required around that '?' (ctx:VxW) > + long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ; > > ERROR: that open brace { should be on the previous line > + const struct ata_port_info *ppi[] = > + { &pdc2027x_port_info[board_idx], NULL }; > > Signed-off-by: Arvind Yadav Patch doesn't apply to libata/for-4.16. Also, please keep Bart's Acked-by when posting updated versions. Thanks. -- tejun