Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbdLET5W (ORCPT ); Tue, 5 Dec 2017 14:57:22 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:45086 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbdLET5U (ORCPT ); Tue, 5 Dec 2017 14:57:20 -0500 From: Vivien Didelot To: David Miller Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net-next 0/5] net: dsa: use per-port upstream port In-Reply-To: <20171205.144727.522098543209254657.davem@davemloft.net> References: <20171204173457.14873-1-vivien.didelot@savoirfairelinux.com> <20171205.144727.522098543209254657.davem@davemloft.net> Date: Tue, 05 Dec 2017 14:57:18 -0500 Message-ID: <87374pdk2p.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 28 Hi David, David Miller writes: > From: Vivien Didelot > Date: Mon, 4 Dec 2017 12:34:52 -0500 > >> An upstream port is a local switch port used to reach a CPU port. >> >> DSA still considers a unique CPU port in the whole switch fabric and >> thus return a unique upstream port for a given switch. This is wrong in >> a multiple CPU ports environment. >> >> We are now switching to using the dedicated CPU port assigned to each >> port in order to get rid of the deprecated unique tree CPU port. >> >> This patchset makes the dsa_upstream_port() helper take a port argument >> and goes one step closer complete support for multiple CPU ports. > > Please adhere to reverse-christmas-tree for variable declarations in > these changes. Totally makes sense for this month of the year, I'm replanting a v2! Thanks, Vivien