Subject: Re: [PATCH v2] drivers:mtd:spi-nor:checkup FSR error bits
To: "Bean Huo (beanhuo)" <beanhuo@micron.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <03b5686314b54957b673cdf092b11c02@SIWEX5A.sing.micron.com>
From: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Message-ID: <763dca19-e290-537d-3008-66d00e796875@wedev4u.fr>
Date: Tue, 5 Dec 2017 21:20:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <03b5686314b54957b673cdf092b11c02@SIWEX5A.sing.micron.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 39

Le 04/12/2017 à 14:27, Bean Huo (beanhuo) a écrit :
> Hi, Cyrille
> 
>> Hi Bean,
>>
>> Le 04/12/2017 à 13:34, Bean Huo (beanhuo) a écrit :
>>> For Micron spi nor device, when erase/program operation fails,
>>> especially the failure results from intending to modify protected
>>> space, spi-nor upper layers still get the return which shows the
>>> operation succeeds. This is because current spi_nor_fsr_ready() only
>>> uses FSR bit.7 (flag status register) to check device whether ready.
>>> This patch fixs this issue by checking relevant error
>>
>> s/fixs/fixes/
>>
>>> bits in FSR.
>>> The FSR is a powerful tool to investigate the staus of
>>
>> s/staus/status/
>>
>>> device, checking information regarding what is actually doing the
>>> memory and detecting possible error conditions.
>>>
>>> Signed-off-by: beanhuo <beanhuo@micron.com>

Applied to the spi-nor/next branch of l2-mtd after correcting few typos
in the commit message and the subject line.

>>
>> Otherwise,
>> Acked-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
>>
>> No need to resend, I'll fix these tiny issues myself :)
>>
> 
> Thanks!
> 
> // Bean Huo
>