Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbdLEU2v (ORCPT ); Tue, 5 Dec 2017 15:28:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43290 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbdLEU2r (ORCPT ); Tue, 5 Dec 2017 15:28:47 -0500 Date: Tue, 5 Dec 2017 22:28:38 +0200 From: "Michael S. Tsirkin" To: Peter Zijlstra Cc: "Paul E. McKenney" , linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, Jason Wang , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends() Message-ID: <20171205222757-mutt-send-email-mst@kernel.org> References: <20171201195053.GA23494@linux.vnet.ibm.com> <1512157876-24665-21-git-send-email-paulmck@linux.vnet.ibm.com> <20171205202928-mutt-send-email-mst@kernel.org> <20171205183946.GP3165@worktop.lehotels.local> <20171205204928-mutt-send-email-mst@kernel.org> <20171205191733.GQ3165@worktop.lehotels.local> <20171205212053-mutt-send-email-mst@kernel.org> <20171205193339.GP7829@linux.vnet.ibm.com> <20171205215020-mutt-send-email-mst@kernel.org> <20171205195752.GS3165@worktop.lehotels.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171205195752.GS3165@worktop.lehotels.local> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 05 Dec 2017 20:28:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 601 Lines: 20 On Tue, Dec 05, 2017 at 08:57:52PM +0100, Peter Zijlstra wrote: > On Tue, Dec 05, 2017 at 09:51:48PM +0200, Michael S. Tsirkin wrote: > > > > WRITE_ONCE(obj->val, 1); > > > > smp_wmb(); > > > > WRITE_ONCE(*foo, obj); > > > > > > I believe Peter was instead suggesting: > > > > > > WRITE_ONCE(obj->val, 1); > > > smp_store_release(foo, obj); > > > > Isn't that more expensive though? > > Depends on the architecture. The only architecture where it is more > expensive and people actually still care about is ARM I think. Right. Why should I use the more expensive smp_store_release then? -- MST