Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752189AbdLEVaw (ORCPT ); Tue, 5 Dec 2017 16:30:52 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:44298 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbdLEVav (ORCPT ); Tue, 5 Dec 2017 16:30:51 -0500 X-Google-Smtp-Source: AGs4zMYR8S7A2Oujc3eIg+MhfUNr58RIjPJ40HQ+3Q0h7Wno+iK3z+KbXdXUHGJxJ8rGR4CELPS1VV0vY4aawBjUJm0= MIME-Version: 1.0 In-Reply-To: <20171121092911.GA150711@sofia> References: <20171121092911.GA150711@sofia> From: Richard Weinberger Date: Tue, 5 Dec 2017 22:30:49 +0100 Message-ID: Subject: Re: [PATCH] scripts/faddr2line: extend usage on generic arch To: "Liu, Changcheng" Cc: kstewart@linuxfoundation.org, Neil Brown , Thomas Gleixner , Greg KH , LKML , Andrew Morton Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 27 On Tue, Nov 21, 2017 at 10:29 AM, Liu, Changcheng wrote: > fadd2line script should use the binary tool > used for the target system. > > Signed-off-by: Liu Changcheng > > diff --git a/scripts/faddr2line b/scripts/faddr2line > index 1f5ce95..39e07d8 100755 > --- a/scripts/faddr2line > +++ b/scripts/faddr2line > @@ -44,9 +44,16 @@ > set -o errexit > set -o nounset > > +READELF="${CROSS_COMPILE}readelf" > +ADDR2LINE="${CROSS_COMPILE}addr2line" > +SIZE="${CROSS_COMPILE}size" > +NM="${CROSS_COMPILE}nm" How is this supposed to work when not cross compiling? When CROSS_COMPILE is not set this script will terminate because of the "set -o nounset" bash setting... -- Thanks, //richard