Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752429AbdLEVuf (ORCPT ); Tue, 5 Dec 2017 16:50:35 -0500 Received: from ale.deltatee.com ([207.54.116.67]:53376 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752209AbdLEVue (ORCPT ); Tue, 5 Dec 2017 16:50:34 -0500 To: Serge Semin , Jon Mason Cc: Dave Jiang , "Hubbe, Allen" , "S-k, Shyam-sundar" , "Yu, Xiangliang" , Gary R Hook , Sergey.Semin@t-platforms.ru, linux-ntb , linux-kernel References: <20171203191736.3399-1-fancer.lancer@gmail.com> <20171203191736.3399-5-fancer.lancer@gmail.com> <20171205195335.GE1701@mobilestation> From: Logan Gunthorpe Message-ID: <11050889-2014-fcbc-4314-e9bd6bbc9224@deltatee.com> Date: Tue, 5 Dec 2017 14:50:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171205195335.GE1701@mobilestation> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, Sergey.Semin@t-platforms.ru, gary.hook@amd.com, Xiangliang.Yu@amd.com, Shyam-sundar.S-k@amd.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, jdmason@kudzu.us, fancer.lancer@gmail.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2 04/15] NTB: ntb_pp: Add full multi-port NTB API support X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 17 On 05/12/17 12:53 PM, Serge Semin wrote: > Is it really necessary to have all of this info defined in macro? We don't use > them anywhere in the source below. I add this change here due to the last Greg > patch, where he removed DRIVER_LICENSE from the code. He said, that the license > check tool needs it to be directly defined in the MODULE_LICENSE. The rest of > macro aren't used by any tool, but still there might be some utility in future > to collect all the driver authors or descriptions. Still if you think it is > unnecessary and it's ok to still have the macro left here, I'll get them back > to the drivers code. No one's arguing against the actual change, only that it does not belong in this patch. If you want to make the change send it as it's own patch with it's own justification and we can discuss it there. Logan