Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752270AbdLEV7p (ORCPT ); Tue, 5 Dec 2017 16:59:45 -0500 Received: from imap1.codethink.co.uk ([176.9.8.82]:51032 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbdLEV7o (ORCPT ); Tue, 5 Dec 2017 16:59:44 -0500 Message-ID: <1512511180.18523.185.camel@codethink.co.uk> Subject: Re: [PATCH 4.4 20/96] autofs: dont fail mount for transient error From: Ben Hutchings To: NeilBrown Cc: stable@vger.kernel.org, Ian Kent , Andrew Morton , Linus Torvalds , Greg Kroah-Hartman , LKML Date: Tue, 05 Dec 2017 21:59:40 +0000 In-Reply-To: <20171128100504.403972166@linuxfoundation.org> References: <20171128100503.067621614@linuxfoundation.org> <20171128100504.403972166@linuxfoundation.org> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 949 Lines: 39 On Tue, 2017-11-28 at 11:22 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > ------------------ > > From: NeilBrown > > commit ecc0c469f27765ed1e2b967be0aa17cee1a60b76 upstream. [...] > @@ -173,7 +175,18 @@ static void autofs4_notify_daemon(struct >   mutex_unlock(&sbi->wq_mutex); >   >   if (autofs4_write(sbi, pipe, &pkt, pktsz)) > + switch (ret = autofs4_write(sbi, pipe, &pkt, pktsz)) { I'm pretty sure the if-statement was meant to be replaced by the switch-statement here. (This is wrong upstream, not an error in backporting.) Ben. > + case 0: > + break; > + case -ENOMEM: > + case -ERESTARTSYS: > + /* Just fail this one */ > + autofs4_wait_release(sbi, wq->wait_queue_token, ret); > + break; > + default: >   autofs4_catatonic_mode(sbi); > + break; > + } >   fput(pipe); >  } >   -- Ben Hutchings Software Developer, Codethink Ltd.