Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752289AbdLEWW2 (ORCPT ); Tue, 5 Dec 2017 17:22:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:42787 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbdLEWWY (ORCPT ); Tue, 5 Dec 2017 17:22:24 -0500 From: NeilBrown To: Ben Hutchings Date: Wed, 06 Dec 2017 09:22:15 +1100 Cc: stable@vger.kernel.org, Ian Kent , Andrew Morton , Linus Torvalds , Greg Kroah-Hartman , LKML Subject: Re: [PATCH 4.4 20/96] autofs: dont fail mount for transient error In-Reply-To: <1512511180.18523.185.camel@codethink.co.uk> References: <20171128100503.067621614@linuxfoundation.org> <20171128100504.403972166@linuxfoundation.org> <1512511180.18523.185.camel@codethink.co.uk> Message-ID: <87wp20stm0.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2165 Lines: 74 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Dec 05 2017, Ben Hutchings wrote: > On Tue, 2017-11-28 at 11:22 +0100, Greg Kroah-Hartman wrote: >> 4.4-stable review patch.=C2=A0=C2=A0If anyone has any objections, please= let me know. >>=20 >> ------------------ >>=20 >> From: NeilBrown >>=20 >> commit ecc0c469f27765ed1e2b967be0aa17cee1a60b76 upstream. > [...] >> @@ -173,7 +175,18 @@ static void autofs4_notify_daemon(struct >> =C2=A0 mutex_unlock(&sbi->wq_mutex); >> =C2=A0 >> =C2=A0 if (autofs4_write(sbi, pipe, &pkt, pktsz)) >> + switch (ret =3D autofs4_write(sbi, pipe, &pkt, pktsz)) { > > I'm pretty sure the if-statement was meant to be replaced by the > switch-statement here. (This is wrong upstream, not an error in > backporting.) Argg yes. Thanks for the review!!! Fix posted. Thanks, NeilBrown > > Ben. > >> + case 0: >> + break; >> + case -ENOMEM: >> + case -ERESTARTSYS: >> + /* Just fail this one */ >> + autofs4_wait_release(sbi, wq->wait_queue_token, ret); >> + break; >> + default: >> =C2=A0 autofs4_catatonic_mode(sbi); >> + break; >> + } >> =C2=A0 fput(pipe); >> =C2=A0} >> =C2=A0 > > --=20 > Ben Hutchings > Software Developer, Codethink Ltd. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlonHBcACgkQOeye3VZi gblKHw//Zm/3DXek6GroQW00SfVfVt0yQjWdG54pN2NC1XwaSVV9k8/lMEq9lU3/ TX1gHVZ5Ss/p5qLHcQUQVTox9X8k1r0XyNRsY4n/rbuHeV79yRKWHQ8F96AijqUV KsQEuLUGJvFTMUmXLrhBidwFM/5SGO9v+DPX5pQBUEsC5HvQnHowu1WKMt+VgWjg aRyJfY4fUAOCDzjWJ4fA7bmFB4qbIl+E26iO19q8dTug4/sniVzEb/1vsY533obo N/v0+htJ6jQTuEpac40gRBSx4n/Yx5BaD/fJazch2DxcE7pLaFtPn6fijFMHn356 UEDyNmH0Lv+Jkzj4GIGquyhcirzthXRyDMZldRkxJdOd/ZJf2R3iHg3SZ/kopwGm 5snnEg9ycToFlRr77yIqm23hot8lUX0eSO8drtHRJGB/1NVtdEagc5j//CNflAs2 kVntRneSjEXfamiHaZ1DypDeEJqMO1UMHoABMTCQo6+AZR1b97urM6jNSw10kpI6 XqIMoLQtGPv7ApIuxeYIjG2CWqX7Fu2r27Vo7WsyAIurpVc6fip5LDo2Dveuls3L Ks9rJc22U63gHYE0JM4yNP7iWIhpfUv1HitRXN7zO0lpkbzMZrNUmD/2a6frZO9a 5a70Ixy15HjTrUHsEVL6cbFzBZyeJoeLDRb9rS8nQiZOVpJsfrw= =LAdZ -----END PGP SIGNATURE----- --=-=-=--