Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752585AbdLEWeW (ORCPT ); Tue, 5 Dec 2017 17:34:22 -0500 Received: from forward2p.cmail.yandex.net ([77.88.31.17]:40344 "EHLO forward2p.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbdLEWeS (ORCPT ); Tue, 5 Dec 2017 17:34:18 -0500 Authentication-Results: mxback3j.mail.yandex.net; dkim=pass header.i=@yandex.ru From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: Colin King Cc: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <20171107184914.7561-1-colin.king@canonical.com> References: <20171107184914.7561-1-colin.king@canonical.com> Subject: Re: [PATCH] w1: remove redundant assignments to search_bit and last_rn MIME-Version: 1.0 Message-Id: <803221512513255@web55j.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Wed, 06 Dec 2017 01:34:15 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 41 Hi 07.11.2017, 21:49, "Colin King" : > From: Colin Ian King > > Variables search_bit and last_rn are assigned values before a while-loop > however these initial values are never read (as they are overwritten > inside the loop). Thus these initial assignments are redundant and can > be removed. Cleans up clang warnings: > > drivers/w1/w1.c:967:2: warning: Value stored to 'search_bit' is never > read > drivers/w1/w1.c:969:2: warning: Value stored to 'last_rn' is never read This looks good, thank you. Please pull it into janitors tree if you haven't yet. > Signed-off-by: Colin Ian King Acked-by: Evgeniy Polyakov > --- >  drivers/w1/w1.c | 2 -- >  1 file changed, 2 deletions(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index 0c2a5a8327bd..c29f6c5dda3c 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/w1.c > @@ -964,9 +964,7 @@ void w1_search(struct w1_master *dev, u8 search_type, w1_slave_found_callback cb >          int search_bit, desc_bit; >          u8 triplet_ret = 0; > > - search_bit = 0; >          rn = dev->search_id; > - last_rn = 0; >          last_device = 0; >          last_zero = -1; > > -- > 2.14.1