Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753082AbdLEXgr (ORCPT ); Tue, 5 Dec 2017 18:36:47 -0500 Received: from ale.deltatee.com ([207.54.116.67]:54284 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbdLEXgq (ORCPT ); Tue, 5 Dec 2017 18:36:46 -0500 To: Serge Semin , jdmason@kudzu.us, dave.jiang@intel.com, Allen.Hubbe@emc.com, Shyam-sundar.S-k@amd.com, Xiangliang.Yu@amd.com, gary.hook@amd.com Cc: linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org References: <20171203191736.3399-1-fancer.lancer@gmail.com> <20171205223918.28727-1-fancer.lancer@gmail.com> <20171205223918.28727-2-fancer.lancer@gmail.com> From: Logan Gunthorpe Message-ID: <922d0bdc-d6ab-e3b5-e930-d24255a440f1@deltatee.com> Date: Tue, 5 Dec 2017 16:36:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171205223918.28727-2-fancer.lancer@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, gary.hook@amd.com, Xiangliang.Yu@amd.com, Shyam-sundar.S-k@amd.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, jdmason@kudzu.us, fancer.lancer@gmail.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v3 01/15] NTB: Rename NTB messaging API methods X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 400 Lines: 12 On 05/12/17 03:39 PM, Serge Semin wrote: > There is a common methods signature form used over all the NTB API > like functions naming scheme, arguments names and order, etc. > Recently added NTB messaging API IO callbacks were named a bit > different so should be renamed to be in compliance with the rest > of the API. I still think we should not do this so this patch gets a NAK from me. Logan