Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753554AbdLFBXQ (ORCPT ); Tue, 5 Dec 2017 20:23:16 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:45836 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753320AbdLFBXM (ORCPT ); Tue, 5 Dec 2017 20:23:12 -0500 X-Google-Smtp-Source: AGs4zMatASmfEvWpDmRN+dyoHlN/vgdK+GCrKzivxE4FbUIj7DXFZm+H+X87y9COS5tDi/yYUlhILQ== Date: Tue, 5 Dec 2017 17:23:13 -0800 From: Nicolin Chen To: "Maciej S. Szmigiero" Cc: broonie@kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, fabio.estevam@nxp.com, timur@tabi.org, caleb@crome.org, lgirdwood@gmail.com Subject: Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level Message-ID: <20171206012312.GA11876@Asurada-Nvidia> References: <1512420403-10164-1-git-send-email-nicoleotsuka@gmail.com> <81e17b9c-e878-1fe9-bb6f-b074d5766232@maciej.szmigiero.name> <20171205193258.GA11039@Asurada-Nvidia> <1cbd2b92-30c3-4f07-e9ab-8c9a2d342800@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1cbd2b92-30c3-4f07-e9ab-8c9a2d342800@maciej.szmigiero.name> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 23 On Wed, Dec 06, 2017 at 02:01:32AM +0100, Maciej S. Szmigiero wrote: > >>> ==Verification== > >>> Theoretically, it only needs code review, build and sanity tests. I > >>> have done build and sanity tests on an i.MX 6 platform by building > >>> using imx_v6_v7_defconfig and testing with I2S slave/master mode. > > > >> Due to my current workload I will be able to go through this and test > >> the AC'97 mode on a UDOO board only in about a week. > > > > This is the first round which doesn't touch program flow. If you > > prefer to verify it other than merely reviewing it, I would like > > to wait for your Tested-by. There will be another set to simplify > > all functions and their program flows after this set gets merged. > > That one will need to be fully tested. > > If you can wait a week then naturally it would be better to test > these changes on a real board. I can wait for a week. I think Timur will also want to justify for some changes. So I need time to revise and rebase as well -- I've some patches for the 2nd set already, so rebasing would take some time.