Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753375AbdLFBhC (ORCPT ); Tue, 5 Dec 2017 20:37:02 -0500 Received: from mga06.intel.com ([134.134.136.31]:48958 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753275AbdLFBg6 (ORCPT ); Tue, 5 Dec 2017 20:36:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,366,1508828400"; d="scan'208";a="184046774" Date: Wed, 6 Dec 2017 09:35:47 +0800 From: "Liu, Changcheng" To: Richard Weinberger Cc: neilb@suse.com, tglx@linutronix.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, kstewart@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scripts/faddr2line: extend usage on generic arch Message-ID: <20171206013547.GB83929@sofia> References: <20171121092911.GA150711@sofia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 952 Lines: 32 On 22:30 Tue 05 Dec, Richard Weinberger wrote: > On Tue, Nov 21, 2017 at 10:29 AM, Liu, Changcheng > wrote: > > fadd2line script should use the binary tool > > used for the target system. > > > > Signed-off-by: Liu Changcheng > > > > diff --git a/scripts/faddr2line b/scripts/faddr2line > > index 1f5ce95..39e07d8 100755 > > --- a/scripts/faddr2line > > +++ b/scripts/faddr2line > > @@ -44,9 +44,16 @@ > > set -o errexit > > set -o nounset > > > > +READELF="${CROSS_COMPILE}readelf" > > +ADDR2LINE="${CROSS_COMPILE}addr2line" > > +SIZE="${CROSS_COMPILE}size" > > +NM="${CROSS_COMPILE}nm" > > How is this supposed to work when not cross compiling? > When CROSS_COMPILE is not set this script will terminate because of > the "set -o nounset" bash setting... [Changcheng]:@Richard. Thx for your check. I've sent the fix patch to resolve the unbound variable error. > > -- > Thanks, > //richard