From: "Z.q. Hou" <zhiqiang.hou@nxp.com>
To: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "computersforpeace@gmail.com" <computersforpeace@gmail.com>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "boris.brezillon@free-electrons.com" 
        <boris.brezillon@free-electrons.com>,
        "marek.vasut@gmail.com" <marek.vasut@gmail.com>,
        "richard@nod.at" <richard@nod.at>
Subject: RE: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop
 using the flash
Thread-Topic: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop
 using the flash
Thread-Index: AQHTbY0yy+zaGmnKf0qhKPUpagEllqM1N5WAgABc7MA=
Date: Wed, 6 Dec 2017 02:17:36 +0000
Message-ID: <AM5PR0402MB2771F2A6E98B974709C394B184320@AM5PR0402MB2771.eurprd04.prod.outlook.com>
References: <20171205053322.35823-1-Zhiqiang.Hou@nxp.com>
 <0b8fae88-cff4-41ac-2613-09bb671ec070@wedev4u.fr>
In-Reply-To: <0b8fae88-cff4-41ac-2613-09bb671ec070@wedev4u.fr>
Accept-Language: zh-CN, en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e663e1e-31b5-47e8-8609-08d53c4f847a
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2017 02:17:36.4092
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2769
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vB62HmUi004863
Content-Length: 1561
Lines: 49

Hi Cyrille,

Thanks a lot for your comments!

> -----Original Message-----
> From: Cyrille Pitchen [mailto:cyrille.pitchen@wedev4u.fr]
> Sent: 2017年12月6日 4:41
> To: Z.q. Hou <zhiqiang.hou@nxp.com>; linux-mtd@lists.infradead.org;
> linux-kernel@vger.kernel.org; computersforpeace@gmail.com;
> dwmw2@infradead.org; boris.brezillon@free-electrons.com;
> marek.vasut@gmail.com; richard@nod.at
> Subject: Re: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when
> stop using the flash
> 
> Hi Hou,
> 
> Le 05/12/2017 à 06:33, Zhiqiang Hou a écrit :
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > To be compatible with legacy device, reset the addressing mode to the
> > default mode. Such as Freescale eSPI boot, it copies the images from
> > SPI flash without firing a reset signal previously, so the reboot
> > command will fail without reseting the addressing mode of SPI flash.
> >
> 
> You should put this in one of the commit messages so it explains which issue is
> fixed by your patches.

Agree with you, and will do it in next version.

> 
> Otherwise, your series looks good to me :)
> 
> Best regards,
> 
> Cyrille
> 
> > Hou Zhiqiang (2):
> >   mtd: spi-nor: add an API to restore the status of SPI flash chip
> >   mtd: m25p80: restore the status of SPI flash when stop using it
> >
> >  Documentation/mtd/spi-nor.txt |  3 +++  drivers/mtd/devices/m25p80.c
> > |  9 +++++++++  drivers/mtd/spi-nor/spi-nor.c | 10 ++++++++++
> >  include/linux/mtd/spi-nor.h   |  6 ++++++
> >  4 files changed, 28 insertions(+)
> >

Thanks,
Zhiqiang