Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754336AbdLFCTy (ORCPT ); Tue, 5 Dec 2017 21:19:54 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:39747 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753275AbdLFCTw (ORCPT ); Tue, 5 Dec 2017 21:19:52 -0500 X-Google-Smtp-Source: AGs4zMYl7AwgF1uWISxPrNeVCAu97rNuo1h2jpKYIjPf1iSPONtqYq3paAakZ7A9JVX/2EkM40CurA== Subject: Re: [PATCH] netlink: Add netns check on taps To: Kevin Cernekee , davem@davemloft.net Cc: johannes.berg@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1512513982-20407-1-git-send-email-cernekee@chromium.org> From: David Ahern Message-ID: Date: Tue, 5 Dec 2017 19:19:49 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1512513982-20407-1-git-send-email-cernekee@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1323 Lines: 34 On 12/5/17 3:46 PM, Kevin Cernekee wrote: > Currently, a nlmon link inside a child namespace can observe systemwide > netlink activity. Filter the traffic so that in a non-init netns, > nlmon can only sniff netlink messages from its own netns. > > Test case: > > vpnns -- bash -c "ip link add nlmon0 type nlmon; \ > ip link set nlmon0 up; \ > tcpdump -i nlmon0 -q -w /tmp/nlmon.pcap -U" & > sudo ip xfrm state add src 10.1.1.1 dst 10.1.1.2 proto esp \ > spi 0x1 mode transport \ > auth sha1 0x6162633132330000000000000000000000000000 \ > enc aes 0x00000000000000000000000000000000 > grep abc123 /tmp/nlmon.pcap > > Signed-off-by: Kevin Cernekee > --- > net/netlink/af_netlink.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c > index b9e0ee4..88381a2 100644 > --- a/net/netlink/af_netlink.c > +++ b/net/netlink/af_netlink.c > @@ -253,6 +253,11 @@ static int __netlink_deliver_tap_skb(struct sk_buff *skb, > struct sock *sk = skb->sk; > int ret = -ENOMEM; > > + if (!net_eq(dev_net(dev), sock_net(sk)) && > + !net_eq(dev_net(dev), &init_net)) { Why is init_net special? Seems like snooping should be limited to the namespace you are in.