Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754525AbdLFCfc (ORCPT ); Tue, 5 Dec 2017 21:35:32 -0500 Received: from mx-fe5-210.meituan.com ([103.37.138.210]:34290 "EHLO mx02.meituan.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754469AbdLFCf1 (ORCPT ); Tue, 5 Dec 2017 21:35:27 -0500 X-Greylist: delayed 71457 seconds by postgrey-1.27 at vger.kernel.org; Tue, 05 Dec 2017 21:35:26 EST DKIM-Filter: OpenDKIM Filter v2.9.2 dx-it-mx02.dx.sankuai.com 92C20297D492 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] writeback: fix comment in __mark_inode_dirty From: wanglong In-Reply-To: <20171205154831.GR2421075@devbig577.frc2.facebook.com> Date: Wed, 6 Dec 2017 10:35:15 +0800 Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, w@laoqinren.net, axboe@fb.com, axboe@kernel.dk Message-Id: References: <1512453174-25575-1-git-send-email-wanglong19@meituan.com> <20171205154831.GR2421075@devbig577.frc2.facebook.com> To: tj@kernel.org X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vB62ZaiT006655 Content-Length: 842 Lines: 33 Cc: Jens Axboe > On 5 Dec 2017, at 11:48 PM, tj@kernel.org wrote: > > Hello, Wang. > > On Tue, Dec 05, 2017 at 12:52:54AM -0500, Wang Long wrote: >> Signed-off-by: Wang Long >> --- >> fs/fs-writeback.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c >> index cea4836..8d477cf 100644 >> --- a/fs/fs-writeback.c >> +++ b/fs/fs-writeback.c >> @@ -2209,7 +2209,7 @@ void __mark_inode_dirty(struct inode *inode, int flags) >> trace_writeback_dirty_inode_enqueue(inode); >> >> /* >> - * If this is the first dirty inode for this bdi, >> + * If this is the first dirty inode for this wb, > > Acked-by: Tejun Heo > > This probably should go through the block tree tho. Please cc Jens > Axboe. > > Thanks. > > -- > tejun