Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754480AbdLFCkv (ORCPT ); Tue, 5 Dec 2017 21:40:51 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:41606 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753808AbdLFCks (ORCPT ); Tue, 5 Dec 2017 21:40:48 -0500 X-Google-Smtp-Source: AGs4zMaeXnsMargzP9YO9WOdEW1gVUCkP8Zf5zwtGf5gcin2TC4gARcdPxiViZnZVMQTpD5L/BmHoQ== Subject: Re: [PATCH v3 0/2] of: overlay: Fix of_overlay_apply() error path To: Geert Uytterhoeven , Pantelis Antoniou , Rob Herring Cc: Colin King , Dan Carpenter , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1512487623-30450-1-git-send-email-geert+renesas@glider.be> From: Frank Rowand Message-ID: <48dd6ac2-6481-4164-6051-ec9fd98490fb@gmail.com> Date: Tue, 5 Dec 2017 21:40:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1512487623-30450-1-git-send-email-geert+renesas@glider.be> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 26 On 12/05/17 10:27, Geert Uytterhoeven wrote: > Hi Pantelis, Rob, Frank, > > Here's a replacement for commit bd80e2555c5c9d45 ("of: overlay: Fix > cleanup order in of_overlay_apply()"), which was applied by Rob, and > dropped later. > > The first patch fixes the memory leak reported by Colin. > The second patch is a replacement for the bad dropped commit, and > depends on the first patch for proper cleanup. > > All OF unittests pass. > > Thanks! > > Geert Uytterhoeven (2): > of: overlay: Fix memory leak in of_overlay_apply() error path > of: overlay: Fix (un)locking in of_overlay_apply() > > drivers/of/overlay.c | 31 +++++++++++++------------------ > 1 file changed, 13 insertions(+), 18 deletions(-) > Thank you, the code is much improved by these patches. Reviewed-by: Frank Rowand