Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754599AbdLFDHP (ORCPT ); Tue, 5 Dec 2017 22:07:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:36182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754350AbdLFDHN (ORCPT ); Tue, 5 Dec 2017 22:07:13 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5640B21882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org From: Masami Hiramatsu To: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu , bhargavb , linux-kernel@vger.kernel.org, Paul Clarke , linux-rt-users@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: [PATCH 1/5] perf-probe: Add warning message if there is unexpected event name Date: Wed, 6 Dec 2017 12:06:50 +0900 Message-Id: <151252961042.12861.5722227511177610862.stgit@devbox> X-Mailer: git-send-email 2.13.6 In-Reply-To: <151252958056.12861.954203514347167563.stgit@devbox> References: <151252958056.12861.954203514347167563.stgit@devbox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 35 This improve the error message so that user can know event-name error before writing new events to kprobe-events interface. E.g. ====== #./perf probe -x /lib64/libc-2.25.so malloc_get_state* Internal error: "malloc_get_state@GLIBC_2" is wrong event name. Error: Failed to add events. ====== Signed-off-by: Masami Hiramatsu --- tools/perf/util/probe-event.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index b7aaf9b2294d..c0067950e56f 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -2625,6 +2625,14 @@ static int get_new_event_name(char *buf, size_t len, const char *base, out: free(nbase); + + /* Final validation */ + if (ret >= 0 && !is_c_func_name(buf)) { + pr_warning("Internal error: \"%s\" is wrong event name.\n", + buf); + ret = -EINVAL; + } + return ret; }