Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753285AbdLFG6S convert rfc822-to-8bit (ORCPT ); Wed, 6 Dec 2017 01:58:18 -0500 Received: from smtprelay2.synopsys.com ([198.182.60.111]:58143 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087AbdLFG6O (ORCPT ); Wed, 6 Dec 2017 01:58:14 -0500 From: John Youn To: Dinh Nguyen , "John.Youn@synopsys.com" CC: "felipe.balbi@linux.intel.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: dwc2: add optional usb ecc reset bit Thread-Topic: [PATCH] usb: dwc2: add optional usb ecc reset bit Thread-Index: AQHTUyb8Bkqrb0XCbEaboyz7SPOC4A== Date: Wed, 6 Dec 2017 06:58:13 +0000 Message-ID: <2B3535C5ECE8B5419E3ECBE300772909026A024874@US01WEMBX2.internal.synopsys.com> References: <1509550493-1924-1-git-send-email-dinguyen@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.186.99] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1725 Lines: 55 On 11/01/2017 08:35 AM, Dinh Nguyen wrote: > The dwc2 USB controller in Stratix10 has an additional ECC reset bit that > needs to get de-asserted in order for the controller to work properly. > > Signed-off-by: Dinh Nguyen > --- > drivers/usb/dwc2/core.h | 1 + > drivers/usb/dwc2/platform.c | 10 ++++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h > index 8367d4f9..a4b5f4e 100644 > --- a/drivers/usb/dwc2/core.h > +++ b/drivers/usb/dwc2/core.h > @@ -920,6 +920,7 @@ struct dwc2_hsotg { > int irq; > struct clk *clk; > struct reset_control *reset; > + struct reset_control *reset_ecc; > > unsigned int queuing_high_bandwidth:1; > unsigned int srp_success:1; > diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c > index daf0d37..d466e03 100644 > --- a/drivers/usb/dwc2/platform.c > +++ b/drivers/usb/dwc2/platform.c > @@ -220,6 +220,15 @@ static int dwc2_lowlevel_hw_init(struct dwc2_hsotg *hsotg) > > reset_control_deassert(hsotg->reset); > > + hsotg->reset_ecc = devm_reset_control_get_optional(hsotg->dev, "dwc2-ecc"); > + if (IS_ERR(hsotg->reset_ecc)) { > + ret = PTR_ERR(hsotg->reset_ecc); > + dev_err(hsotg->dev, "error getting reset control for ecc %d\n", ret); > + return ret; > + } > + > + reset_control_deassert(hsotg->reset_ecc); > + > /* Set default UTMI width */ > hsotg->phyif = GUSBCFG_PHYIF16; > > @@ -318,6 +327,7 @@ static int dwc2_driver_remove(struct platform_device *dev) > dwc2_lowlevel_hw_disable(hsotg); > > reset_control_assert(hsotg->reset); > + reset_control_assert(hsotg->reset_ecc); > > return 0; > } > Acked-by: John Youn John