Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754272AbdLFJPx (ORCPT ); Wed, 6 Dec 2017 04:15:53 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34680 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753656AbdLFJPt (ORCPT ); Wed, 6 Dec 2017 04:15:49 -0500 Date: Wed, 6 Dec 2017 10:15:53 +0100 From: "'Greg KH'" To: Dhaval Rajeshbhai Shah Cc: "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "michal.simek@xilinx.com" , Hyun Kwon Subject: Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver Message-ID: <20171206091553.GB23022@kroah.com> References: <1512474212-12803-1-git-send-email-dshah@xilinx.com> <20171205133002.GB13746@kroah.com> <20171206075604.GA920@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 17 On Wed, Dec 06, 2017 at 09:05:51AM +0000, Dhaval Rajeshbhai Shah wrote: > > Then you need to explain this a lot better, posting a random driver for > > submission that is expected to be used by another one isn't ok. > > Post the whole patch series please, we do not add infrastructure to the > > kernel that is not used right then. > Can I remove the export api and header file and make this driver generic for the logicoreIP? No other driver will depend on that. This will help us to remove the isolation between the Programmable system and Programmable logic by configuring the logicoreIp register set. I don't know, let's see what that patch submission looks like. If it doesn't do anything, that's not really a good idea :) What's wrong with just submitting your entire driver series? Why break it up like this? That's normally not a good idea, you want us to review it in a "whole" idea, not piece-meal. thanks, greg k-h