Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754641AbdLFJaW convert rfc822-to-8bit (ORCPT ); Wed, 6 Dec 2017 04:30:22 -0500 Received: from smtp.ctxuk.citrix.com ([185.25.65.24]:19165 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754150AbdLFJaU (ORCPT ); Wed, 6 Dec 2017 04:30:20 -0500 X-IronPort-AV: E=Sophos;i="5.45,367,1508803200"; d="scan'208";a="64281544" From: Paul Durrant To: "'Joe Perches'" , Wei Liu CC: "xen-devel@lists.xenproject.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] xen-netback: Fix logging message with spurious period after newline Thread-Topic: [PATCH] xen-netback: Fix logging message with spurious period after newline Thread-Index: AQHTbl0enmjOb0uWYUykhcXgwhlPKKM2DM7w Date: Wed, 6 Dec 2017 09:30:17 +0000 Message-ID: <1f7b9f45512d4b84b1775efe88a3eb98@AMSPEX02CL03.citrite.net> References: <7884b866cbeba808b63d9de871ace53970561f41.1512542267.git.joe@perches.com> In-Reply-To: <7884b866cbeba808b63d9de871ace53970561f41.1512542267.git.joe@perches.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 38 > -----Original Message----- > From: Joe Perches [mailto:joe@perches.com] > Sent: 06 December 2017 06:40 > To: Wei Liu ; Paul Durrant > Cc: xen-devel@lists.xenproject.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH] xen-netback: Fix logging message with spurious period > after newline > > Using a period after a newline causes bad output. > > Signed-off-by: Joe Perches Reviewed-by: Paul Durrant > --- > drivers/net/xen-netback/interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen- > netback/interface.c > index d6dff347f896..78ebe494fef0 100644 > --- a/drivers/net/xen-netback/interface.c > +++ b/drivers/net/xen-netback/interface.c > @@ -186,7 +186,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct > net_device *dev) > /* Obtain the queue to be used to transmit this packet */ > index = skb_get_queue_mapping(skb); > if (index >= num_queues) { > - pr_warn_ratelimited("Invalid queue %hu for packet on > interface %s\n.", > + pr_warn_ratelimited("Invalid queue %hu for packet on > interface %s\n", > index, vif->dev->name); > index %= num_queues; > } > -- > 2.15.0