Subject: Re: [PATCH v2] pata_pdc2027x: Fix coding sytle errors
To: Arvind Yadav <arvind.yadav.cs@gmail.com>, b.zolnierkie@samsung.com,
        tj@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
References: <1512498399-23577-1-git-send-email-arvind.yadav.cs@gmail.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <3a37d055-8ded-a8d3-8af8-b58f58726849@cogentembedded.com>
Date: Wed, 6 Dec 2017 12:43:14 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1512498399-23577-1-git-send-email-arvind.yadav.cs@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 821
Lines: 30

On 12/5/2017 9:26 PM, Arvind Yadav wrote:

> Fix these checkpatch.pl errors:
> Fix checkpatch.pl error:

    Why repeat it twice?

> ERROR: space prohibited before open square bracket '['.
> 
> ERROR: space prohibited after that '~' (ctx:WxW)
> +		mask &= ~ (1 << (6 + ATA_SHIFT_UDMA));
> 
> ERROR: spaces required around that '?' (ctx:VxW)
> +	long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
> 
> ERROR: that open brace { should be on the previous line
> +	const struct ata_port_info *ppi[] =
> +		{ &pdc2027x_port_info[board_idx], NULL };
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2:
>               Subject and description was not correct.
>               *s/sytle error/style errors/ in the patch summary

    You didn't really fix the subject. :-/

[...]

MBR, Sergei