Subject: Re: [PATCH] firmware: qcom: scm: Fix incorrect of_node_put call in
 scm_init
To: Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jerome Brunet <jbrunet@baylibre.com>
References: <1512489134-28220-1-git-send-email-lollivier@baylibre.com>
From: Loys Ollivier <lollivier@baylibre.com>
Message-ID: <0aae19bc-d1b8-3f61-0646-eaea021d8518@baylibre.com>
Date: Wed, 6 Dec 2017 10:54:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1512489134-28220-1-git-send-email-lollivier@baylibre.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1125
Lines: 32

Please discard this patch. The if statement becoming a one liner, the
curly brackets should be removed. I will send a v2.

On 05/12/2017 16:52, Loys Ollivier wrote:
> When using other platform architectures, in the init of the qcom_scm
> driver, of_node_put is called on /firmware if no qcom dt is found.
> This results in a kernel error: Bad of_node_put() on /firmware.
> 
> The call to of_node_put from the qcom_scm init is unnecessary as
> of_find_matching_node is calling it automatically.
> 
> Remove this of_node_put().
> 
> Fixes: d0f6fa7ba2d6 ("firmware: qcom: scm: Convert SCM to platform driver")
> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
> ---
>  drivers/firmware/qcom_scm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index af4c75217ea6..575930c80fba 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -633,7 +633,6 @@ static int __init qcom_scm_init(void)
>  	np = of_find_matching_node(fw_np, qcom_scm_dt_match);
>  
>  	if (!np) {
> -		of_node_put(fw_np);
>  		return -ENODEV;
>  	}
>  
>