Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755025AbdLFK1i (ORCPT ); Wed, 6 Dec 2017 05:27:38 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:37538 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755127AbdLFK1I (ORCPT ); Wed, 6 Dec 2017 05:27:08 -0500 Subject: Re: [linux-next][41e83b9][gcc 4.8.5] make modules fail at net/netfilter/xt_bpf.ko From: Abdul Haleem To: Al Viro Cc: sachinp , Stephen Rothwell , linux-kernel , linux-next , linuxppc-dev Date: Wed, 06 Dec 2017 15:56:59 +0530 In-Reply-To: <20171205180650.GV21978@ZenIV.linux.org.uk> References: <1512484991.13113.11.camel@abdul> <20171205180650.GV21978@ZenIV.linux.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 17120610-0020-0000-0000-00000D1EDC54 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008159; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000244; SDB=6.00956202; UDB=6.00483336; IPR=6.00736239; BA=6.00005729; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018378; XFM=3.00000015; UTC=2017-12-06 10:27:05 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120610-0021-0000-0000-00005F309AC4 Message-Id: <1512556019.13113.18.camel@abdul> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-06_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712060152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1115 Lines: 41 On Tue, 2017-12-05 at 18:06 +0000, Al Viro wrote: > On Tue, Dec 05, 2017 at 08:13:11PM +0530, Abdul Haleem wrote: > > Hi Al Viro, > > > > Today's next kernel build failed with commit 41e83b9: fix "netfilter: > > xt_bpf: Fix XT_BPF_MODE_FD_PINNED > > > > Machine Type: Power 7 > > kernel version: 4.15.0-rc2-next-20171204 > > kernel config: attached > > test: 'make modules' > > > > ERROR: ".bpf_prog_get_type_path" [net/netfilter/xt_bpf.ko] undefined! > > > > Kernel built fine when bad commit is reverted. > > In the same commit there's > > +EXPORT_SYMBOL(bpf_prog_get_type_path); > > so I really wonder WTF is going on... > > Oh, I see. !BPF_SYSCALL and NETFILTER_XT_MATCH_BPF in .config triggers > that. Incremental (to be folded into the commit in question) follows: Thank you for the patch, the build succeeded. But I see some new warnings. ./include/linux/bpf.h: In function ‘bpf_prog_get_type_path’: ./include/linux/bpf.h:515:2: warning: return makes pointer from integer without a cast [enabled by default] return -EOPNOTSUPP; ^ -- Regard's Abdul Haleem IBM Linux Technology Centre