Subject: Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in
 rf69_enum.h
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: =?UTF-8?Q?Simon_Sandstr=c3=b6m?= <simon@nikanor.nu>,
        gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux@Wolf-Entwicklungen.de, linux-kernel@vger.kernel.org
References: <20171205220849.5486-1-simon@nikanor.nu>
 <20171205220849.5486-5-simon@nikanor.nu>
 <4c89dc10-ccce-7760-f806-3a19c3edf743@smarthome-wolf.de>
 <20171206100833.3ficksukt6xaazl4@mwanda>
From: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
Message-ID: <2ebc402d-f2af-40cb-7aa2-c9f062a0dd3d@smarthome-wolf.de>
Date: Wed, 6 Dec 2017 12:31:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171206100833.3ficksukt6xaazl4@mwanda>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1013
Lines: 43


Am 06.12.2017 um 12:23 schrieb Dan Carpenter:
> On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote:
>>> diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h
>>> index babe597e2ec6..5247e9269de9 100644
>>> --- a/drivers/staging/pi433/rf69_enum.h
>>> +++ b/drivers/staging/pi433/rf69_enum.h
>>> @@ -18,9 +18,9 @@
>>>    #ifndef RF69_ENUM_H
>>>    #define RF69_ENUM_H
>>> -enum optionOnOff {
>>> -	optionOff,
>>> -	optionOn
>>> +enum option_on_off {
>>> +	OPTION_OFF,
>>> +	OPTION_ON
>>>    };
>>>    enum mode {
>>>
>>
>> Hi Simon,
>>
>> nice work.
>>
>> Thank you very much for all the style fixes :-)
>>
> 
> 
> Wow...  This was the one patch I thought was going to sink this
> patchset... 

I don't get that. What do you mean?

> Isn't enum optionOnOff part of the userspace headers?
> 
> I thought we weren't allowed to change that.

All enums are for user space (or inteded to be used in userspace in 
future). Didn't introduce enums for internal use.

Reagrds,
Marcus