Subject: Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into
 two functions
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: =?UTF-8?Q?Simon_Sandstr=c3=b6m?= <simon@nikanor.nu>,
        gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux@Wolf-Entwicklungen.de, linux-kernel@vger.kernel.org
References: <20171205220849.5486-1-simon@nikanor.nu>
 <20171205220849.5486-7-simon@nikanor.nu>
 <d8308dc7-f9da-f01e-de39-59780603f879@smarthome-wolf.de>
 <20171206093703.bgs32doff7svvdf5@mwanda>
From: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
Message-ID: <e282e9ec-d42d-f03e-aa8e-918ffefffb1f@smarthome-wolf.de>
Date: Wed, 6 Dec 2017 12:36:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171206093703.bgs32doff7svvdf5@mwanda>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 851
Lines: 25


 >>
 >> rf69 -set/get - action
 >> -> rf69_set_crc_enable
 >
 > No...  Simon's name is better.  His is shorter and makes more sense.


I disagree. If I am going to implement a new functionality and need to 
think about the naming of the function name, every time I need to change 
a register setting that's awfull.

I usually have code on one monitor and datasheet on the other. So if I 
want to set a bit/reg/whatever, I have the datasheet in front of my 
nose. I can easy write the code, if function names refer to the names in 
the datasheet and follow a strict naming convention. If the naming 
convetion is broken, I need to switch to the header and search manually 
for each register, I want to set.


There is so much potential in this young driver, that could be 
developed. Would be pitty, if all that wouldn't take place some day.


Marcus