Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755074AbdLFKsP (ORCPT ); Wed, 6 Dec 2017 05:48:15 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:50656 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096AbdLFKsO (ORCPT ); Wed, 6 Dec 2017 05:48:14 -0500 Date: Wed, 6 Dec 2017 13:44:14 +0300 From: Dan Carpenter To: Marcus Wolf Cc: Simon =?iso-8859-1?Q?Sandstr=F6m?= , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux@Wolf-Entwicklungen.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h Message-ID: <20171206104414.xv2yqldf5xjovxxr@mwanda> References: <20171205220849.5486-1-simon@nikanor.nu> <20171205220849.5486-5-simon@nikanor.nu> <4c89dc10-ccce-7760-f806-3a19c3edf743@smarthome-wolf.de> <20171206100833.3ficksukt6xaazl4@mwanda> <2ebc402d-f2af-40cb-7aa2-c9f062a0dd3d@smarthome-wolf.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ebc402d-f2af-40cb-7aa2-c9f062a0dd3d@smarthome-wolf.de> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8736 signatures=668641 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712060157 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1389 Lines: 48 On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: > > > Am 06.12.2017 um 12:23 schrieb Dan Carpenter: > > On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: > > > > diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h > > > > index babe597e2ec6..5247e9269de9 100644 > > > > --- a/drivers/staging/pi433/rf69_enum.h > > > > +++ b/drivers/staging/pi433/rf69_enum.h > > > > @@ -18,9 +18,9 @@ > > > > #ifndef RF69_ENUM_H > > > > #define RF69_ENUM_H > > > > -enum optionOnOff { > > > > - optionOff, > > > > - optionOn > > > > +enum option_on_off { > > > > + OPTION_OFF, > > > > + OPTION_ON > > > > }; > > > > enum mode { > > > > > > > > > > Hi Simon, > > > > > > nice work. > > > > > > Thank you very much for all the style fixes :-) > > > > > > > > > Wow... This was the one patch I thought was going to sink this > > patchset... > > I don't get that. What do you mean? > > > Isn't enum optionOnOff part of the userspace headers? > > > > I thought we weren't allowed to change that. > > All enums are for user space (or inteded to be used in userspace in future). > Didn't introduce enums for internal use. So what I'm asking is if we do this change, does it break any userspace programs which are used *right now*. In other words will programs stop compiling because we've renamed an enum? regards, dan carpenter