Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754937AbdLFKyc (ORCPT ); Wed, 6 Dec 2017 05:54:32 -0500 Received: from ozlabs.org ([103.22.144.67]:60025 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754788AbdLFKya (ORCPT ); Wed, 6 Dec 2017 05:54:30 -0500 From: Michael Ellerman To: Shilpasri G Bhat , linux-pm@vger.kernel.org Cc: "Gautham R. Shenoy" , viresh.kumar@linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, huntbag@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, akshay.adiga@linux.vnet.ibm.com Subject: Re: [PATCH] cpufreq: powernv: Define methods to parse positive & negative pstates In-Reply-To: <1512017018-4857-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> References: <1512017018-4857-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> Date: Wed, 06 Dec 2017 21:54:27 +1100 Message-ID: <87r2s8dt3w.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 486 Lines: 14 Shilpasri G Bhat writes: > From: "Gautham R. Shenoy" > > Pstates are 8bit values but on POWER8 they are negative and on POWER9 > they are positive. This patch adds helper routines to differentiate > the sign to read the correct pstate value. This sounds like it could be a bad bug, but I can't really tell from the change log. What is the actual impact of not having this patch? Should it have a Fixes/Cc-stable tag? cheers