Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755134AbdLFLEQ (ORCPT ); Wed, 6 Dec 2017 06:04:16 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:33663 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755103AbdLFLEP (ORCPT ); Wed, 6 Dec 2017 06:04:15 -0500 From: Fabien DESSENNE To: Corentin Labbe , "herbert@gondor.apana.org.au" , Alexandre TORGUE , "arei.gonglei@huawei.com" , "davem@davemloft.net" , "jasowang@redhat.com" , "mcoquelin.stm32@gmail.com" , "mst@redhat.com" , Lionel DEBIEVE CC: "linux-arm-kernel@lists.infradead.org" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH RFC 4/4] crypto: stm32: convert to the new crypto engine API Thread-Topic: [PATCH RFC 4/4] crypto: stm32: convert to the new crypto engine API Thread-Index: AQHTaO4uh9GQtU47UUerc+cQW2Ag4KM2IQYA Date: Wed, 6 Dec 2017 11:03:23 +0000 Message-ID: <5835a2df-64d2-1363-15a3-eec4db955d58@st.com> References: <20171129084121.9385-1-clabbe.montjoie@gmail.com> <20171129084121.9385-5-clabbe.montjoie@gmail.com> In-Reply-To: <20171129084121.9385-5-clabbe.montjoie@gmail.com> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.50] Content-Type: text/plain; charset="utf-8" Content-ID: <53C74EB7E53A664B9ADDA336340EDC82@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-06_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB6B4JDe017007 Content-Length: 3301 Lines: 90 Hi, On 29/11/17 09:41, Corentin Labbe wrote: > This patch convert the driver to the new crypto engine API. > > Signed-off-by: Corentin Labbe Tested-by: Fabien Dessenne > --- > drivers/crypto/stm32/stm32-hash.c | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c > index 4ca4a264a833..e3f9f7b04ce2 100644 > --- a/drivers/crypto/stm32/stm32-hash.c > +++ b/drivers/crypto/stm32/stm32-hash.c > @@ -122,6 +122,7 @@ enum stm32_hash_data_format { > #define HASH_DMA_THRESHOLD 50 > > struct stm32_hash_ctx { > + struct crypto_engine_reqctx enginectx; > struct stm32_hash_dev *hdev; > unsigned long flags; > > @@ -811,7 +812,7 @@ static void stm32_hash_finish_req(struct ahash_request *req, int err) > rctx->flags |= HASH_FLAGS_ERRORS; > } > > - crypto_finalize_hash_request(hdev->engine, req, err); > + crypto_finalize_request(hdev->engine, &req->base, err); > } > > static int stm32_hash_hw_init(struct stm32_hash_dev *hdev, > @@ -828,15 +829,21 @@ static int stm32_hash_hw_init(struct stm32_hash_dev *hdev, > return 0; > } > > +static int stm32_hash_one_request(struct crypto_engine *engine, > + struct crypto_async_request *areq); > +static int stm32_hash_prepare_req(struct crypto_engine *engine, > + struct crypto_async_request *areq); > + > static int stm32_hash_handle_queue(struct stm32_hash_dev *hdev, > struct ahash_request *req) > { > - return crypto_transfer_hash_request_to_engine(hdev->engine, req); > + return crypto_transfer_request_to_engine(hdev->engine, &req->base); > } > > static int stm32_hash_prepare_req(struct crypto_engine *engine, > - struct ahash_request *req) > + struct crypto_async_request *areq) > { > + struct ahash_request *req = ahash_request_cast(areq); > struct stm32_hash_ctx *ctx = crypto_ahash_ctx(crypto_ahash_reqtfm(req)); > struct stm32_hash_dev *hdev = stm32_hash_find_dev(ctx); > struct stm32_hash_request_ctx *rctx; > @@ -855,8 +862,9 @@ static int stm32_hash_prepare_req(struct crypto_engine *engine, > } > > static int stm32_hash_one_request(struct crypto_engine *engine, > - struct ahash_request *req) > + struct crypto_async_request *areq) > { > + struct ahash_request *req = ahash_request_cast(areq); > struct stm32_hash_ctx *ctx = crypto_ahash_ctx(crypto_ahash_reqtfm(req)); > struct stm32_hash_dev *hdev = stm32_hash_find_dev(ctx); > struct stm32_hash_request_ctx *rctx; > @@ -1033,6 +1041,9 @@ static int stm32_hash_cra_init_algs(struct crypto_tfm *tfm, > if (algs_hmac_name) > ctx->flags |= HASH_FLAGS_HMAC; > > + ctx->enginectx.op.do_one_request = stm32_hash_one_request; > + ctx->enginectx.op.prepare_request = stm32_hash_prepare_req; > + ctx->enginectx.op.unprepare_request = NULL; > return 0; > } > > @@ -1493,9 +1504,6 @@ static int stm32_hash_probe(struct platform_device *pdev) > goto err_engine; > } > > - hdev->engine->prepare_hash_request = stm32_hash_prepare_req; > - hdev->engine->hash_one_request = stm32_hash_one_request; > - > ret = crypto_engine_start(hdev->engine); > if (ret) > goto err_engine_start;