Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752235AbdLFM6z (ORCPT ); Wed, 6 Dec 2017 07:58:55 -0500 Received: from agrajag.zerfleddert.de ([88.198.237.222]:51694 "EHLO agrajag.zerfleddert.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbdLFM6x (ORCPT ); Wed, 6 Dec 2017 07:58:53 -0500 X-Greylist: delayed 502 seconds by postgrey-1.27 at vger.kernel.org; Wed, 06 Dec 2017 07:58:53 EST Date: Wed, 6 Dec 2017 13:50:29 +0100 From: Tobias Jordan To: Mark Brown , Maxime Ripard , Chen-Yu Tsai , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC] spi: sun6i: disable/unprepare clocks on remove Message-ID: <20171206125028.fqzmy354tgf7afis@agrajag.zerfleddert.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 31 sun6i_spi_probe() uses sun6i_spi_runtime_resume() to prepare/enable clocks, so sun6i_spi_remove() should use sun6i_spi_runtime_suspend() to disable/unprepare them. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 3558fe900e8af spi: sunxi: Add Allwinner A31 SPI controller driver Signed-off-by: Tobias Jordan --- This was found by LDV, and it looks very suspicious to me, but I'm not sure if the fix is that easy. Is suspend() called automatically when the driver is removed? If not, is it correct to unconditionally call suspend(), or should there be a check for the PM state instead? drivers/spi/spi-sun6i.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c index fb38234249a8..5e5df09e5d04 100644 --- a/drivers/spi/spi-sun6i.c +++ b/drivers/spi/spi-sun6i.c @@ -541,6 +541,7 @@ static int sun6i_spi_probe(struct platform_device *pdev) static int sun6i_spi_remove(struct platform_device *pdev) { + sun6i_spi_runtime_suspend(&pdev->dev); pm_runtime_disable(&pdev->dev); return 0; -- 2.11.0