Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbdLFNiB (ORCPT ); Wed, 6 Dec 2017 08:38:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36572 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbdLFNiA (ORCPT ); Wed, 6 Dec 2017 08:38:00 -0500 Date: Wed, 6 Dec 2017 14:37:52 +0100 From: Jiri Olsa To: John Garry Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, namhyung@kernel.org, ak@linux.intel.com, wcohen@redhat.com, will.deacon@arm.com, ganapatrao.kulkarni@cavium.com, catalin.marinas@arm.com, mark.rutland@arm.com, xuwei5@hisilicon.com, linuxarm@huawei.com, zhangshaokun@hisilicon.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/5] perf jevents: add support for arch recommended events Message-ID: <20171206133752.GB12508@krava> References: <1512490399-94107-1-git-send-email-john.garry@huawei.com> <1512490399-94107-3-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512490399-94107-3-git-send-email-john.garry@huawei.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 06 Dec 2017 13:38:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1120 Lines: 41 On Wed, Dec 06, 2017 at 12:13:16AM +0800, John Garry wrote: SNIP > --- > tools/perf/pmu-events/jevents.c | 215 ++++++++++++++++++++++++++++++++++++---- > 1 file changed, 198 insertions(+), 17 deletions(-) > > diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c > index a0d489e..a820ed4 100644 > --- a/tools/perf/pmu-events/jevents.c > +++ b/tools/perf/pmu-events/jevents.c > @@ -42,6 +42,7 @@ > #include > #include /* getrlimit */ > #include /* getrlimit */ > +#include > #include > #include > #include "jsmn.h" > @@ -366,6 +367,94 @@ static int print_events_table_entry(void *data, char *name, char *event, > return 0; > } > > +struct event_struct { > + char *name; > + char *event; > + char *desc; > + char *long_desc; > + char *pmu; > + char *unit; > + char *perpkg; > + char *metric_expr; > + char *metric_name; > + char *metric_group; > + LIST_ENTRY(event_struct) list; is there any reason you don't use the 'struct list_head' ? I dont think we want another thingie involved for lists jirka