Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbdLFOLo (ORCPT ); Wed, 6 Dec 2017 09:11:44 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:36146 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbdLFOLo (ORCPT ); Wed, 6 Dec 2017 09:11:44 -0500 Date: Wed, 6 Dec 2017 14:11:39 +0000 From: Mark Rutland To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, ard.biesheuvel@linaro.org, sboyd@codeaurora.org, dave.hansen@linux.intel.com, keescook@chromium.org, msalter@redhat.com, labbott@redhat.com, tglx@linutronix.de Subject: Re: [PATCH v3 16/20] arm64: entry: Add fake CPU feature for unmapping the kernel at EL0 Message-ID: <20171206141138.33mw3tmhwfuh6x3y@lakrids.cambridge.arm.com> References: <1512563739-25239-1-git-send-email-will.deacon@arm.com> <1512563739-25239-17-git-send-email-will.deacon@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512563739-25239-17-git-send-email-will.deacon@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 605 Lines: 20 On Wed, Dec 06, 2017 at 12:35:35PM +0000, Will Deacon wrote: > +static bool unmap_kernel_at_el0(const struct arm64_cpu_capabilities *entry, > + int __unused) > +{ > + /* Forced on command line? */ > + if (__kpti_forced) { > + pr_info("kernel page table isolation forced %s by command line option\n", > + __kpti_forced > 0 ? "ON" : "OFF"); > + return __kpti_forced > 0; > + } I think we want this to be a pr_info_once() so that we don't print this for late-onlined secondaries due to verify_local_cpu_features(). With that changed: Reviewed-by: Mark Rutland Thanks, Mark.