Date: Wed, 6 Dec 2017 15:52:28 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Marcus Wolf <linux@wolf-entwicklungen.de>
Cc: dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] staging: pi433: rf69.c: Replace macros READ_REG and
 WRITE_REG with smarter functions
Message-ID: <20171206145228.GA20550@kroah.com>
References: <1512423916-14297-1-git-send-email-linux@wolf-entwicklungen.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1512423916-14297-1-git-send-email-linux@wolf-entwicklungen.de>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 946
Lines: 24

On Mon, Dec 04, 2017 at 11:45:16PM +0200, Marcus Wolf wrote:
> To increase the readability of the register accesses, the abstraction
> of the helpers was increased from simple read and write to set bit,
> clear bit and read modify write bit.
> 
> Annotation: This patch contains a lot of long lines and camel case
> var names. These long lines and camel case vars weren't introduced
> by this patch, but were long and camel cased before.
> 
> Signed-off-by: Marcus Wolf <linux@wolf-entwicklungen.de>
> ---
>  drivers/staging/pi433/rf69.c |  336 ++++++++++++++++++++++--------------------
>  1 file changed, 180 insertions(+), 156 deletions(-)

When doing a second or third or forth version of a patch, always include
below the --- line what changed from the previous versions.  The
in-kernel documentation for how to submit a patch should have all of the
needed information on this.

No need here, just for the future patches.

thanks,

greg k-h