Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752289AbdLFPm0 (ORCPT ); Wed, 6 Dec 2017 10:42:26 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:33204 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbdLFPmV (ORCPT ); Wed, 6 Dec 2017 10:42:21 -0500 X-Google-Smtp-Source: AGs4zMau79uUQyNnQIbXuLyXonWN0x9km5MrcMBykf4C4UtDX2N8+gFz7rgy66V+3ofiLqW7pM5F1w== Date: Wed, 6 Dec 2017 15:42:16 +0000 From: Lee Jones To: Hans de Goede Cc: linux-kernel@vger.kernel.org, Rui Feng Subject: Re: [PATCH] mfd: Fix RTS5227 (and others) powermanagement Message-ID: <20171206154216.p34bksrk4bnx2krq@dell> References: <20171206112135.9332-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1721 Lines: 47 On Wed, 06 Dec 2017, Hans de Goede wrote: > Hi, > > On 06-12-17 12:21, Hans de Goede wrote: > > Commit 8275b77a1513 ("mfd: rts5249: Add support for RTS5250S power > > saving") adds powersaving support for device-ids 5249 524a and 525a. > > > > But as a side effect it breaks ASPM support for all the other device-ids, > > causing e.g. the Haswell CPU on a Lenovo T440s to not go into a higher > > c-state then PC3, while previously it would go to PC7, causing the > > machine to idle at 7.4W instead of 6.6W! > > > > The problem here is the new option.dev_aspm_mode field, which only gets > > explicitly initialized in the new code for the device-ids 5249 524a and > > 525a. Leaving the dev_aspm_mode 0 for the other device-ids. > > > > The default dev_aspm_mode 0 is mapped to DEV_ASPM_DISABLE, but the > > old behavior of calling rtsx_pci_enable_aspm() when idle and > > rtsx_pci_disable_aspm() when busy happens when dev_aspm_mode == > > DEV_ASPM_DYNAMIC. > > > > This commit changes the enum so that 0 = DEV_ASPM_DYNAMIC matching the > > old default behavior, fixing the pm regression with the other device-ids. > > > > Cc: Rui Feng > > Signed-off-by: Hans de Goede > > p.s. > > 2 remarks: > > 1. As this is a regression in 4.15, please queue this up as a fix for 4.15 > (I prioritized bisecting this, which took me a whole day to get a fix > ready in time for 4.15). If this is aimed at -the rcs, you should apply a Fixes: tag. Happy to do it for you this time. Be good to get at Ack from Rui before I apply it. -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog