Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752192AbdLFQD7 (ORCPT ); Wed, 6 Dec 2017 11:03:59 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:49591 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbdLFQD6 (ORCPT ); Wed, 6 Dec 2017 11:03:58 -0500 Date: Wed, 6 Dec 2017 17:03:55 +0100 From: Andrew Lunn To: Tobias Jordan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] net: mvmdio: disable/unprepare clocks in EPROBE_DEFER case Message-ID: <20171206160355.GK27063@lunn.ch> References: <20171206142323.6hbm54leg2maanbj@agrajag.zerfleddert.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171206142323.6hbm54leg2maanbj@agrajag.zerfleddert.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 457 Lines: 14 On Wed, Dec 06, 2017 at 03:23:23PM +0100, Tobias Jordan wrote: > add appropriate calls to clk_disable_unprepare() by jumping to out_mdio > in case orion_mdio_probe() returns -EPROBE_DEFER. > > Found by Linux Driver Verification project (linuxtesting.org). > > Fixes: 3d604da1e954 net: mvmdio: get and enable optional clock > Signed-off-by: Tobias Jordan Reviewed-by: Andrew Lunn Thanks Tobais Andrew