Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752833AbdLFQnZ (ORCPT ); Wed, 6 Dec 2017 11:43:25 -0500 Received: from mail-ot0-f195.google.com ([74.125.82.195]:43206 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752034AbdLFQnP (ORCPT ); Wed, 6 Dec 2017 11:43:15 -0500 X-Google-Smtp-Source: AGs4zMYU3t4f0knrimBeEAi0ceiEIcsQhBP8J7hg9B8YPVs1VmcLF0xbCUseBLcjpEtWtjBJvYFBpf32cOl+blbM81s= MIME-Version: 1.0 In-Reply-To: <20171205143514.4441-3-sven.eckelmann@openmesh.com> References: <20171205143514.4441-1-sven.eckelmann@openmesh.com> <20171205143514.4441-3-sven.eckelmann@openmesh.com> From: Willem de Bruijn Date: Wed, 6 Dec 2017 11:42:33 -0500 Message-ID: Subject: Re: [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h To: Sven Eckelmann Cc: Network Development , "David S . Miller" , Jiri Pirko , Eric Dumazet , LKML , b.a.t.m.a.n@lists.open-mesh.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 15 On Tue, Dec 5, 2017 at 9:35 AM, Sven Eckelmann wrote: > This file contains the relevant information to let userspace communicate > with batman-adv over generic netlink. The relevant genl enums for the > attributes and commands have the prefix batadv_genl. Renaming this file to > this name therefore represents the content better and avoids confusion with > the file which will contain the packet format definitions. > > Signed-off-by: Sven Eckelmann > --- > MAINTAINERS | 2 +- > include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++--- This and the previous patch changes uapi. That might break userspace applications that rely on it.