Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbdLFQzz (ORCPT ); Wed, 6 Dec 2017 11:55:55 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:37942 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752550AbdLFQzq (ORCPT ); Wed, 6 Dec 2017 11:55:46 -0500 X-Google-Smtp-Source: AGs4zMaI/jJBz1seSKndTLbJUvhqYt0o3Vvkcsb3V6E3okd/ZH6MrXcTrg0vIDfsoK/3A9rx0yG4OQ== From: Sven Eckelmann To: b.a.t.m.a.n@lists.open-mesh.org Cc: Willem de Bruijn , Network Development , Eric Dumazet , LKML , Jiri Pirko , "David S . Miller" Subject: Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h Date: Wed, 06 Dec 2017 17:55:42 +0100 Message-ID: <5212497.opIP8sI45N@bentobox> User-Agent: KMail/5.2.3 (Linux/4.13.0-0.bpo.1-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: References: <20171205143514.4441-1-sven.eckelmann@openmesh.com> <20171205143514.4441-3-sven.eckelmann@openmesh.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3624604.65xRJuR1V8"; micalg="pgp-sha512"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2254 Lines: 51 --nextPart3624604.65xRJuR1V8 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Mittwoch, 6. Dezember 2017 11:42:33 CET Willem de Bruijn wrote: > On Tue, Dec 5, 2017 at 9:35 AM, Sven Eckelmann > wrote: > > This file contains the relevant information to let userspace communicate > > with batman-adv over generic netlink. The relevant genl enums for the > > attributes and commands have the prefix batadv_genl. Renaming this file to > > this name therefore represents the content better and avoids confusion with > > the file which will contain the packet format definitions. > > > > Signed-off-by: Sven Eckelmann > > --- > > MAINTAINERS | 2 +- > > include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++--- > > This and the previous patch changes uapi. That might break userspace > applications that rely on it. I am not aware of any application because all (alfred, batctl and some gluon integration) of them currently ship their own copy because distribution didn't catch up. And this is also the reason why I want to do it now - not later. Kind regards, Sven --nextPart3624604.65xRJuR1V8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAlooIQ4ACgkQXYcKB8Em e0Z2dg//aVIEsE1Q1yQrKVlNo8//RoXXRbMeKfe1eDEYqiqAwEIClkfC40pZPIYR BKZTKxgbPzHuQ6+6eG50ujZzVDxu6QDXJmu8ZzF3Tvfa55piwEeuKKUHhGoZG5so ATOXoImqlMi9VXpSawCWAwsLguziAPbvms9eWkQvSIp6ywFW3DtuFE1Dwo8HrQ+W b65FxTckfn1l5XpT2D5nOSJ6IsDFgIex9k6aGW1mXiUXlZ/ougLfMz8vTujZWMnz hWvPoR+43HoX+uyetuAad7dA/q887k4HcqY6WoKWwwzq2IEeCyP/9Pturq7t2XmF xZAOG7xMXm2WSeNT+zlkDLgcPwT/eJzqyA3mFGGPQeSfQJTxxE0hGKqheZmnVL3D dTgqcies9Km5Di/9qGe/s7urXxVMtUEl5uLA4xuKgt+aHLpsQauapB2Xhkrshnae 8fp2XOEeH3fq6qE9F9pluPYIKis+cqBQUE5YAOTBz+jYxzQXZZ1uKlGa8r+Be8eN f0QOvv0FErCmSZIVc05xrJfaOtCecOSJEhrtXh34UyYrH5KhtHLHKHqumD6gasmN HweHCmXIDOhL7oKKyE6YaLZvBIZAwwAHKLZSJEPCigj/K/125o9L0E4ZwXWXuzm/ GtbPDrrGaG4r/MMBrUQna+nlkc6MbH8N6YPTADIZPFw89cC6J1k= =rz26 -----END PGP SIGNATURE----- --nextPart3624604.65xRJuR1V8--